Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds an option to not use triangle inequality in voronoi trees and monodromy #576

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

PBrdng
Copy link
Collaborator

@PBrdng PBrdng commented Jun 12, 2024

No description provided.

@PBrdng
Copy link
Collaborator Author

PBrdng commented Jun 12, 2024

When the function used for metric does not satisfy the triangle inequality, monodromy can be faulty. This PR adds an option triangle_inequality, such that triangle_inequality = false overrides all checks based on the triangle inequality.

@PBrdng PBrdng merged commit 424764c into main Jun 12, 2024
6 checks passed
@PBrdng PBrdng deleted the voronoi_override branch June 12, 2024 17:06
@saschatimme
Copy link
Member

I guess the function is then also not a metric 😅

@PBrdng
Copy link
Collaborator Author

PBrdng commented Jun 13, 2024

Yes, true. But there can be situations where it makes sense to pass a function that measures distances, but is not a metric in the mathematical sense. Should we rename metric to distance in UniquePoints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants