Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable rand tests #305

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 26, 2024

We do not have a way to obtain a stable multi-dimensional array of random numbers. That situation does not change with StableRNGs.
I think it is sufficient here just to make sure that the API works.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.64%. Comparing base (142353d) to head (eedc47d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   84.31%   83.64%   -0.68%     
==========================================
  Files           8        9       +1     
  Lines         778      746      -32     
==========================================
- Hits          656      624      -32     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimikage
Copy link
Collaborator Author

From another perspective, ColorTypes.jl also does not need to guarantee the stability of random numbers (colors).

@kimikage
Copy link
Collaborator Author

kimikage commented Apr 28, 2024

It seems that macos-latest has moved from macos-12 to macos-14.
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Julia Version 1.12.0-DEV.426
Commit 9f37ba86093 (2024-04-28 01:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: macOS (x86_64-apple-darwin22.4.0)
  CPU: 3 × Apple M1 (Virtual)
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, westmere)
Threads: 1 default, 0 interactive, 1 GC (on 3 virtual cores)

However, the binary appears to be for x86_64 macOS 13.

Anyway, we may need to reconsider the targets.

@kimikage
Copy link
Collaborator Author

@kimikage kimikage merged commit d2467df into JuliaGraphics:master Apr 28, 2024
7 of 18 checks passed
@kimikage kimikage deleted the fix_rand_test branch April 28, 2024 09:20
@kimikage kimikage added the ci Continuous integration label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant