Add Oklab and Oklch #291
Merged
Add Oklab and Oklch #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell, this is complete yes. |
|
That's as good as some of the other colorspaces, so I'm fine with that. |
|
Thanks! Getting this out in a release is a little complicated: we already have some breaking stuff merged and there's still #251. Are you in a hurry to get this out or is a bit of a delay OK? |
|
It would be useful for some long term project, but there's no rush. Of course, the complementary pull request in Colors.jl depends on a release here. |
stillyslalom
pushed a commit
to stillyslalom/ColorTypes.jl
that referenced
this pull request
Feb 6, 2024
johnnychen94
pushed a commit
that referenced
this pull request
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to pull request #271 using the terminology of CSS instead and including some tests.
As far as I can tell, I implemented everything needed. The
gamutminandgamutmaxare from the CSS recommendation, but I'm not 100% certain it stays within the sRGB gamut, rather likely it does not.