remove tests that check that Base does not have certain features #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @timholy |
1 similar comment
|
cc @timholy |
|
Sorry for the delay. Doing a release is a bit complicated because we have breaking stuff merged to master. Do you need me to backport this? (Is this about PkgEval?) |
|
No rush, I know I've reported this here so I can filter it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests like this that check that certain features in Base do not exist are kind of pointless. They start failing once Base implements does features and the only thing to do is to remove the tests. In 1.10 this does not error so the tests fail.