Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 3-colorant mapc #282

Merged
merged 2 commits into from
May 24, 2022
Merged

Implement 3-colorant mapc #282

merged 2 commits into from
May 24, 2022

Conversation

timholy
Copy link
Member

@timholy timholy commented May 24, 2022

This will be useful for supporting clamp

@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-0.11@533fbc8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.11     #282   +/-   ##
===============================================
  Coverage                ?   82.41%           
===============================================
  Files                   ?        8           
  Lines                   ?      779           
  Branches                ?        0           
===============================================
  Hits                    ?      642           
  Misses                  ?      137           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533fbc8...b34aa27. Read the comment docs.

johnnychen94
johnnychen94 approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to update the docstring R139

"""
"""
    mapc(f, rgb) -> rgbf
    mapc(f, rgb1, rgb2) -> rgbf
...
"""

@timholy timholy merged commit e5e001a into release-0.11 May 24, 2022
@timholy timholy deleted the teh/mapc_3arg branch May 24, 2022 23:26
@kimikage
Copy link
Collaborator

It would probably be kinder to have a compat admonition.

@kimikage kimikage mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timholy @kimikage @johnnychen94