Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorTypes v0.12.0-dev #281

Merged
merged 1 commit into from
May 15, 2022
Merged

ColorTypes v0.12.0-dev #281

merged 1 commit into from
May 15, 2022

Conversation

johnnychen94
Copy link
Member

To avoid unexpected version bump such as #273

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #281 (28fcdb9) into master (b8ed378) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files           8        8           
  Lines         777      777           
=======================================
  Hits          653      653           
  Misses        124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ed378...28fcdb9. Read the comment docs.

@johnnychen94 johnnychen94 merged commit 79a9f80 into master May 15, 2022
@johnnychen94 johnnychen94 deleted the jc/0.12.0-dev branch May 15, 2022 09:39
@kimikage
Copy link
Collaborator

kimikage commented Apr 30, 2024

@johnnychen94
I believe that this is definitely better to have because an "accident" have actually happened.

However, there is some ambiguity regarding the intent of this.
That is, I don't know if these “-dev” declarations are restrictions on the package itself, or restrictions that also apply to downstream packages.
To change the perspective, the question is whether ColorTypes v0.12.0 should include FixedPointNumbers v0.9.0-dev (or simply v0.9) in the [compat], or not.

As of three years ago, ColorTypes v0.12 was scheduled to drop support for FixedPointNumbers v0.8 and earlier.
While some planning changes are necessary, I believe that is still a reasonable choice as it stands.
Dropping can be done at release time, but adding must be done during development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants