Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isequal (#272) #279

Merged
merged 1 commit into from
May 15, 2022
Merged

Support isequal (#272) #279

merged 1 commit into from
May 15, 2022

Conversation

timholy
Copy link
Member

@timholy timholy commented May 15, 2022

Formerly we fell back to ==, but this does not do the right thing
for NaN components.

(cherry picked from commit b8ed378)

Backported to the release-0.11 branch.

Formerly we fell back to `==`, but this does not do the right thing
for `NaN` components.

(cherry picked from commit b8ed378)
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #279 (f314808) into release-0.11 (a9b5382) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           release-0.11     #279      +/-   ##
================================================
+ Coverage         82.52%   82.64%   +0.11%     
================================================
  Files                 8        8              
  Lines               767      772       +5     
================================================
+ Hits                633      638       +5     
  Misses              134      134              
Impacted Files Coverage Δ
src/operations.jl 99.18% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b5382...f314808. Read the comment docs.

@johnnychen94 johnnychen94 merged commit ad6279b into release-0.11 May 15, 2022
@johnnychen94 johnnychen94 deleted the teh/isequal2 branch May 15, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants