Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support isequal #272

Merged
merged 1 commit into from
May 10, 2022
Merged

Support isequal #272

merged 1 commit into from
May 10, 2022

Conversation

timholy
Copy link
Member

@timholy timholy commented May 10, 2022

Formerly we fell back to ==, but this does not do the right thing
for NaN components.

@timholy
Support isequal
bcbc959 
Formerly we fell back to `==`, but this does not do the right thing
for `NaN` components.
@timholy
Copy link
Member Author

timholy commented May 10, 2022

Let's run CI (I re-enabled UnitTest).

@timholy timholy closed this May 10, 2022
@timholy timholy reopened this May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #272 (bcbc959) into master (6cbe7ab) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   83.93%   84.04%   +0.10%     
==========================================
  Files           8        8              
  Lines         772      777       +5     
==========================================
+ Hits          648      653       +5     
  Misses        124      124
Impacted Files Coverage Δ
src/operations.jl 98.64% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbe7ab...bcbc959. Read the comment docs.

@timholy timholy merged commit b8ed378 into master May 10, 2022
@timholy timholy deleted the teh/isequal branch May 10, 2022 12:38
johnnychen94 added a commit that referenced this pull request May 15, 2022
@johnnychen94
Revert "Support isequal (#272)"
908f5ed 
This reverts commit b8ed378.
timholy added a commit that referenced this pull request May 15, 2022
@timholy
Support isequal (#272)
0571014 
Formerly we fell back to `==`, but this does not do the right thing
for `NaN` components.

(cherry picked from commit b8ed378)
timholy added a commit that referenced this pull request May 15, 2022
@timholy
Support isequal (#272)
f314808 
Formerly we fell back to `==`, but this does not do the right thing
for `NaN` components.

(cherry picked from commit b8ed378)
johnnychen94 pushed a commit that referenced this pull request May 15, 2022
@timholy
Support isequal (#272) (#279)
ad6279b 
Formerly we fell back to `==`, but this does not do the right thing
for `NaN` components.

(cherry picked from commit b8ed378)
@kimikage kimikage mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnychen94 johnnychen94 johnnychen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timholy @johnnychen94