Add Oklab perceptual color space #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnychen94
reviewed
Jan 2, 2022
There was a problem hiding this comment.
I don't know much about color spaces so can't give detailed feedback here.
They're a list of traits in https://github.com/JuliaGraphics/ColorTypes.jl#traits-utility-functions-for-instances-and-types. Maybe you can check and implement all of them that make sense for Oklab and LCHOklab? Conversions between Oklab/LCHklab from/to other color spaces might also need to be supported.
Tests are needed to ensure things work as expected.
| chroma(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Luv} = sqrt(c.u^2 + c.v^2) | ||
| chroma(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{LCHab,LCHuv}} = c.c | ||
| chroma(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{LCHab,LCHuv, LCHOklab}} = c.c |
There was a problem hiding this comment.
Suggested change
| chroma(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{LCHab,LCHuv, LCHOklab}} = c.c | |
| chroma(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{LCHab,LCHuv,LCHOklab}} = c.c |
|
|
||
| """ | ||
| `hue(c)` returns the hue in degrees. This function does not guarantee that the | ||
| return value is in [0, 360]. | ||
| """ | ||
| hue(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{HSV,HSL,HSI,LCHab,LCHuv}} = c.h | ||
| hue(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{Lab,DIN99,DIN99o,DIN99d}} = | ||
| hue(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{HSV,HSL,HSI,LCHab,LCHuv, LCHOklab}} = c.h |
There was a problem hiding this comment.
Suggested change
| hue(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{HSV,HSL,HSI,LCHab,LCHuv, LCHOklab}} = c.h | |
| hue(c::Union{C,AlphaColor{C},ColorAlpha{C}}) where {C<:Union{HSV,HSL,HSI,LCHab,LCHuv,LCHOklab}} = c.h |
|
@nealmckee is there a reason why this is still a draft PR? |
Merged
|
Superseded by #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Oklab color space as described here: https://bottosson.github.io/posts/oklab/
Adds and exports the type.
Adds Oklab and LCHOklab to the chroma and hue trait accessor functions.
Adds description to the readme.
This is my first contribution to Julia, or any software package for that matter, so help with any oversights would be greatly appreciated. (Am I missing tests for example? They weren’t mentioned in the guidelines on how to extend color types.)
See also JuliaGraphics/Colors.jl#518