disable precompilation due to package load time increase #270
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 82.90% 83.16% +0.25%
==========================================
Files 8 8
Lines 772 772
==========================================
+ Hits 640 642 +2
+ Misses 132 130 -2
Continue to review full report at Codecov.
|
|
I think it is the conclusion, but unless it's urgent I'm planning to hold off a bit on merging this to see if I can finish the changes to precompilation that make make this pain-free. I plan on merging it either way, but is it OK to wait a week or so and see what transpires? |
|
No urgency on my part. |
There was a problem hiding this comment.
Here are some time results:
On package loading @time using ColorTypes:
| Julia versions | branch | time |
|---|---|---|
| 1.6.6 | master | 0.180405 seconds (732.27 k allocations: 55.104 MiB, 12.24% compilation time) |
| 1.6.6 | PR | 0.080280 seconds (343.66 k allocations: 21.347 MiB, 29.31% compilation time) |
| 1.8.0-rc1 | master | 0.144830 seconds (529.27 k allocations: 45.092 MiB, 3.78% compilation time) |
| 1.8.0-rc1 | PR | 0.070891 seconds (310.39 k allocations: 20.815 MiB, 7.50% compilation time) |
On TTFX? @time RGB{N0f8}(1.0, 1.0, 1.0), there seems to be none affect at all?
|
I've cherry-picked this commit and released v0.11.4. |
On my machine, the workload inside the `@precompile_all_calls` goes from 0.3s with the previous precompile script to 0.08s with the new one, a 4x reduction. Given that we don't have precompiles anymore in ColorTypes (see JuliaGraphics/ColorTypes.jl#270, a decision I agree with), this package seems like a good place to have some.
Fixes #269
I am not sure this was the conclusion of the discussion in there but I am putting up this in case it is ok.