Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize conversions within the same base color #264

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

kimikage
Copy link
Collaborator

This supports adding/stripping alpha for colors other than Color3.

Fixes #241

This supports adding/stripping alpha for colors other than `Color3`.
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #264 (cccd730) into master (bd4bad2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files           8        8           
  Lines         735      735           
=======================================
  Hits          616      616           
  Misses        119      119           
Impacted Files Coverage Δ
src/conversions.jl 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4bad2...cccd730. Read the comment docs.

@kimikage kimikage merged commit 8574435 into JuliaGraphics:master Aug 16, 2021
@kimikage kimikage deleted the add_strip_alpha branch August 16, 2021 13:45
johnnychen94 added a commit that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalization of conversions within the same base color (adding/stripping alpha)
1 participant