Add component iterator #260
Conversation
kimikage
force-pushed
the
component_iterator
branch
from
c1a13e9 to
0fd278c
Compare
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 83.76% 83.80% +0.04%
==========================================
Files 8 8
Lines 733 735 +2
==========================================
+ Hits 614 616 +2
Misses 119 119
Continue to review full report at Codecov.
|
kimikage
force-pushed
the
component_iterator
branch
from
0fd278c to
faded62
Compare
| Base.axes(::ComponentIterator{C}) where {N, C <: ColorantN{N}} = (Base.OneTo(N),) | ||
| Base.ndims(::Type{ComponentIterator{C}}) where {C} = 1 | ||
| function Base.broadcastable(itr::ComponentIterator{C}) where {T, N, C <: Colorant{T, N}} | ||
| (itr...,)::NTuple{N, T} |
There was a problem hiding this comment.
I think this should return the iterator itself (itr) instead of the tuple, but I don't know how to handle that well. 😕
kimikage
force-pushed
the
component_iterator
branch
from
faded62 to
f2058d6
Compare
This adds a component iterator as a private API. This re-implements the folding functions with the iterator.
kimikage
force-pushed
the
component_iterator
branch
from
f2058d6 to
a6f4d8d
Compare
| @@ -126,3 +126,6 @@ coloralpha(c::C) where {C<:Color} = coloralpha(C)(c) | |||
| coloralpha(c::C,a) where {C<:Color} = coloralpha(C)(c,a) | |||
| coloralpha(c::C) where {C<:TransparentColor} = coloralpha(base_color_type(C))(color(c), alpha(c)) | |||
| coloralpha(c::C,a) where {C<:TransparentColor} = coloralpha(base_color_type(C))(color(c), a) | |||
|
|
|||
| # Tuple | |||
| Tuple(c::Colorant{T, N}) where {T, N} = (comps(c)...,)::NTuple{N, T} | |||
There was a problem hiding this comment.
Is this the recommended API that people should use?
There was a problem hiding this comment.
Strictly speaking, I don't think the Tuple constructors are a part of public APIs because they don't have docstrings.
However, I don't see a problem with ColorVectorSpace.jl etc. using it internally.
There was a problem hiding this comment.
Of course, some people might argue that Colorant is never iterable.
julia> Tuple(0.5 + 0.5im) # Should `Colorant` really be like `Complex`?
(0.5 + 0.5im,)However, since the design of tuple() and Tuple() are clearly different, I don't think there will be any confusion.
julia> Tuple(1:3)
(1, 2, 3)
julia> tuple(1:3)
(1:3,)There was a problem hiding this comment.
There was a problem hiding this comment.
I'm personally in favor of the Tuple(::Colorant) usage. It's kind of like CartesianIndex, that you can't iterate it but can easily construct an iterable tuple from Tuple or x.I.
|
There is still a lot of room for discussion and improvement, but the iteration feature is useful for addressing the rest of the issues, so I will merge this first. |
This reverts commit bd4bad2.
This adds a component iterator as a "private" API.
This re-implements the folding functions with the iterator.
cf. #190, #247