Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gamutmin/gamutmax based on sRGB gamut #254

Merged
merged 1 commit into from
May 18, 2021

Conversation

kimikage
Copy link
Collaborator

Fixes #125

@kimikage kimikage added this to the 0.12 milestone May 15, 2021
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #254 (4dd5b68) into master (5e3aeb5) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   82.64%   82.85%   +0.20%     
==========================================
  Files           8        8              
  Lines         755      764       +9     
==========================================
+ Hits          624      633       +9     
  Misses        131      131              
Impacted Files Coverage Δ
src/operations.jl 98.37% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3aeb5...4dd5b68. Read the comment docs.

@kimikage kimikage mentioned this pull request May 15, 2021
19 tasks
@kimikage
Copy link
Collaborator Author

If you notice any inappropriate values, please report them. Perhaps the values for YCbCr needs to be redefined.

@kimikage kimikage merged commit fd311ab into JuliaGraphics:master May 18, 2021
@kimikage kimikage deleted the gamutmin_gamutmax branch May 18, 2021 08:00
johnnychen94 added a commit that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gamutmax(LCHab) disagrees with the Colors.jl usage
1 participant