Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractGray an abstract type instead of an alias #252

Merged
merged 1 commit into from
May 18, 2021

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented May 7, 2021

This classifies the properties of real numbers and the properties of the black-gray-white colors.

This should be mostly compatible for a single specific method, but may affect the multiple dispatch or ambiguity.

README.md will be updated with PR #250.

Closes #230

@kimikage kimikage added this to the 0.12 milestone May 7, 2021
@kimikage kimikage mentioned this pull request May 7, 2021
19 tasks
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #252 (6a37cf2) into master (fd311ab) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   82.85%   82.87%   +0.02%     
==========================================
  Files           8        8              
  Lines         764      765       +1     
==========================================
+ Hits          633      634       +1     
  Misses        131      131              
Impacted Files Coverage Δ
src/ColorTypes.jl 100.00% <ø> (ø)
src/types.jl 91.38% <ø> (ø)
src/conversions.jl 86.81% <100.00%> (ø)
src/traits.jl 98.89% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd311ab...6a37cf2. Read the comment docs.

src/types.jl Outdated Show resolved Hide resolved
This classifies the properties of real numbers and
the properties of the black-gray-white colors.
@kimikage kimikage merged commit e674ba9 into JuliaGraphics:master May 18, 2021
@kimikage kimikage deleted the abstractgray branch May 18, 2021 10:13
johnnychen94 added a commit that referenced this pull request May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Distinguishing between AbstractGray{T} and Color{T, 1}
2 participants