Improve compN for non-parametric ColorAlpha types
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimikage
changed the title
compN for non-parametric AlphaColor typescompN for non-parametric ColorAlpha types
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 82.25% 82.28% +0.02%
==========================================
Files 8 8
Lines 727 728 +1
==========================================
+ Hits 598 599 +1
Misses 129 129
Continue to review full report at Codecov.
|
|
It's been half a month since the release of v0.11.0, so I'd like to start the v0.12 series. |
johnnychen94
added a commit
that referenced
this pull request
May 15, 2022
This reverts commit 55b720c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since only
AGray32andARGB32are defined as non-parametricTransparentColortypes, I did not notice this problem, but it would be better to specializecompNforColorAlphaas well asAlphaColor.This is not an urgent issue, since it can be solved by overloading
compNby users or packages which define custom color types. Therefore, I will make this a part of v0.12 instead of v0.11, even though this is a non-breaking change as long asalpha(c)works.