Suppress display of module names for invisible types #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 93.70% 93.75% +0.05%
==========================================
Files 8 8
Lines 699 705 +6
==========================================
+ Hits 655 661 +6
Misses 44 44
Continue to review full report at Codecov.
|
In PR JuliaGraphics#174 (v0.10.0), the module names were displayed for invisible non-concrete types. This suppresses the display of module names. This also completely fixes the problem with display of `AGray32`.
kimikage
force-pushed
the
colorant_string
branch
from
12ec22b to
6bc3c52
Compare
kimikage
commented
Jul 24, 2020
Comment on lines
19
to
26
| for i = 1:N | ||
| show(io, (comp_n[i])(c)) | ||
| i == 1 && show(io, comp1(c)) | ||
| i == 2 && show(io, comp2(c)) | ||
| i == 3 && show(io, comp3(c)) | ||
| i == 4 && show(io, comp4(c)) | ||
| i == 5 && show(io, comp5(c)) | ||
| print(io, i < N ? ',' : ')') # without spaces | ||
| end |
There was a problem hiding this comment.
I think this is compiler-/human-friendly. 😂
timholy
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #174 (v0.10.0), the module names were displayed for invisible non-concrete types. In PR #199, non-parametric types also joined the problem. This suppresses the display of module names.
This also completely fixes the problem with display of
AGray32. (It was accidentally half-fixed in PR #199.)