Skip to content

gamutmax(LCHab) disagrees with the Colors.jl usage #125

Closed
@kimikage

Description

The max saturation of LCHab is defined as 1 in ColorTypes.jl.

gamutmax(::Type{T}) where {T<:LCHab} = (100,1,360)
gamutmin(::Type{T}) where {T<:LCHab} = (0,0,0)

However, in Colors.jl, the saturation comes from the a and b of Lab which are mostly in [-100,100].
https://github.com/JuliaGraphics/Colors.jl/blob/657e265a4cccc9fc32584f7f3505611537bfc79d/src/conversions.jl#L575-L580

Therefore, for the sake of convenience, 100 (or 128) is better for the max saturation, though the actual gamut is not so simple. (See also: #84)

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions