Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pirate show for sparse matrices #129

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Do not pirate show for sparse matrices #129

merged 2 commits into from
Dec 29, 2021

Conversation

heliosdrm
Copy link
Collaborator

This is not convenient anymore, as Julia represents big sparse matrices with Braille patterns since v1.6 (JuliaLang/julia#33821). Actually, perhaps we could even use that representation for AbstractRecurrenceMatrix.

This is not convenient anymore, as Julia represents big sparse matrices with Braille patterns since v1.6 (JuliaLang/julia#33821). Actually, perhaps we could even use that representation for `AbstractRecurrenceMatrix`.
@heliosdrm
Copy link
Collaborator Author

Well, no: for AbstractRecurrenceMatrix the special representation of this package is still convenient, because it incorporates the inversion of the Y-axis, as usual for recurrence plots.

@Datseris
Copy link
Member

ok, but also increment patch version in Project.toml

@heliosdrm heliosdrm requested a review from Datseris December 29, 2021 11:29
@Datseris Datseris merged commit 51d3b14 into master Dec 29, 2021
@Datseris Datseris deleted the show_sparsematrix branch December 29, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants