Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example starting from .mzML file and vendor file format #36

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Y0dler
Copy link
Collaborator

@Y0dler Y0dler commented Nov 6, 2024

Closes #32.
The mzML file was too large to be uploaded to GitHub. A different solution will have to be found.

@Y0dler Y0dler self-assigned this Nov 6, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michaelosthege
Copy link
Member

The notebook looks good 👍

Please add it to the documentation index too.

You can upload the mzML file as an asset to the latest release:

https://github.com/JuBiotech/peak-performance/releases/edit/v0.7.1

@Y0dler
Copy link
Collaborator Author

Y0dler commented Nov 8, 2024

The notebook was modified from an older one so it's already in the index :)

The idea with attaching the *.mzML file to the release was really good so that's what I just did.
I updated the instructions in the notebook accordingly.

Also, I realized that two cell outputs of the notebook were extremely long and were shown in their entirety in the documentation so I changed that while I was at it.

@Y0dler Y0dler merged commit f418866 into main Nov 8, 2024
6 checks passed
@Y0dler Y0dler deleted the issue-32-2 branch November 8, 2024 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle outputs from classical peak integration pipelines
2 participants