Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dump): rpc sanity check for trace_replayBlockTransactions #491

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Jon-Becker
Copy link
Owner

Motivation

Closes #488

Solution

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Benchmark for a81ef42

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 15.0±0.50ms 14.2±0.07ms -5.33%
heimdall_cfg/simple 2.2±0.01ms 2.2±0.01ms 0.00%
heimdall_decoder/seaport 38.5±1.89µs 39.0±2.19µs +1.30%
heimdall_decoder/transfer 3.0±0.26µs 2.7±0.15µs -10.00%
heimdall_decoder/uniswap 10.6±0.74µs 10.4±0.44µs -1.89%
heimdall_decompiler/abi_complex 59.6±1.03ms 59.2±0.50ms -0.67%
heimdall_decompiler/abi_simple 2.2±0.01ms 2.2±0.04ms 0.00%
heimdall_decompiler/sol_complex 70.0±3.55ms 69.0±1.14ms -1.43%
heimdall_decompiler/sol_simple 2.6±0.02ms 2.5±0.01ms -3.85%
heimdall_decompiler/yul_complex 62.4±0.63ms 61.6±0.61ms -1.28%
heimdall_decompiler/yul_simple 2.3±0.01ms 2.3±0.01ms 0.00%
heimdall_disassembler/complex 935.1±36.75µs 955.3±73.65µs +2.16%
heimdall_disassembler/simple 43.7±1.56µs 44.8±2.67µs +2.52%
heimdall_vm/erc20_transfer 344.1±14.66µs 349.2±21.95µs +1.48%
heimdall_vm/fib 849.5±47.81µs 866.9±5.03µs +2.05%
heimdall_vm/ten_thousand_hashes 5.0±0.04s 4.9±0.04s -2.00%

@Jon-Becker Jon-Becker merged commit 9193870 into main Sep 2, 2024
8 checks passed
@Jon-Becker Jon-Becker deleted the jon-becker/fix-488 branch December 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dump): no error if RPC endpoint doesn't support trace_replayBlockTransactions
1 participant