Allow initializing Font with NSFont or UIFont
#109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnSundell
reviewed
May 28, 2020
| @@ -31,6 +31,12 @@ public struct Font { | |||
| resource = .system | |||
| self.size = size | |||
| } | |||
|
|
|||
| /// Initialize an instance with an existing, custom, font. | |||
| public init(font: Loaded) { | |||
There was a problem hiding this comment.
I think here we can drop the external parameter label, so rather than:
Font(font: nativeFont)It would be:
Font(nativeFont)Or what do you think @terhechte?
There was a problem hiding this comment.
Or, an alternative design would be to use something inspired by RawRepresentable, and name the external parameter label rawFont, or nativeFont.
There was a problem hiding this comment.
Yeah, I like it. Makes it clearer. If you're fine with this change, I'd check out the repo and create a proper PR, seems CI failed (I did the editing right on Github, so I never tried to compile it ;)
|
Closed in favor of #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow using a custom monospace font for highlighting. Which is especially useful if, say, the code is embedded into some sort of presentation 😊. An assert could be added to make sure the font is monospace, but I feel like that's not required. If somebody wants to display their code in Comic Sans, all the more power to them