Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cleanafter #738

Merged
merged 4 commits into from
Oct 4, 2018
Merged

Rework cleanafter #738

merged 4 commits into from
Oct 4, 2018

Conversation

Morganamilo
Copy link
Contributor

Fixes #736 and a little more.

Yay first calls 'makepkg --nobuild -fC' to update the pkver. Later on we
call 'makepkg -cf --noectract --noprepare --holdver' to actually build
the package.

Inbetween these two calls we keep the already extracted
sources to save time on the reextract and duplicated call to prepare
(pkgbuilds should not require user input but things such as linux-ck do
and calling prepare twice will actually cause them to promt twice)

We also have two checks. First we see if the package is already
installed and up to date (--needed) and secondly we check if the
package is already built.

If any of these conditions are met we skip building the package. This
leaves a dangling src/ directory as 'makepkg -c' was never ran.

Now if these conditions are met tell makepkg to cleanup and exit.
This makes more sense and falls in line with the structs value which has
always been cleanafter. afterclean is still useable for compatibility
but is undocumented.
@Jguer
Copy link
Owner

Jguer commented Sep 27, 2018

I'm going to push a new release now +/-. Question, do you want to include this in that release by this way:

  • branch master to v8 branch, merge this into said v8 branch, then I handle the tagging and releasing leaving reimplement-config to be merged into master and then this can be rebased on that?

@Morganamilo
Copy link
Contributor Author

I guess if you're releasing right now, leave this for the next one. Although the other thing I'm about to push can be merged right away if you like.

Also I'd like to read #717 before you merge it. Although that's on me for not reading it yet.

@Jguer
Copy link
Owner

Jguer commented Sep 27, 2018

Sure thing, we can still delay the config for a while, so if you want to merge this into master we can then give it a few more days to cooldown for release and rebase reimplement-config again against master when it's time

@Morganamilo Morganamilo merged commit 6ee14d4 into Jguer:master Oct 4, 2018
@Jguer
Copy link
Owner

Jguer commented Oct 4, 2018

Ok, I'll be checking the stability of master to release, and bringing reimplement-config to parity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants