Allow using single core repository setup #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose multiplatform repo to core
|
So to test it, I can simply clone the compose-multiplaform-core repo (nr/core-standalone branch) without compose-multiplatform and submodules. And it should work, right? |
|
@eymar yes! Except android everything should work fine |
eymar
reviewed
Apr 18, 2023
dima-avdeev-jb
approved these changes
Apr 18, 2023
|
Also, I have a not important suggestion to rename DEVELOPMENT.md to MULTIPLATFORM.md |
dima-avdeev-jb
approved these changes
Apr 18, 2023
eymar
pushed a commit
that referenced
this pull request
May 1, 2023
* Move README.md from compose-multiplatform repo to core * Move scripts from compose-multiplatform to core * Move fonts from compose multiplatform repo to core * Update scripts to support single core repository setup --------- Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
eymar
pushed a commit
that referenced
this pull request
May 1, 2023
* Move README.md from compose-multiplatform repo to core * Move scripts from compose-multiplatform to core * Move fonts from compose multiplatform repo to core * Update scripts to support single core repository setup --------- Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
igordmn
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Move README.md from compose-multiplatform repo to core * Move scripts from compose-multiplatform to core * Move fonts from compose multiplatform repo to core * Update scripts to support single core repository setup --------- Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
igordmn
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Move README.md from compose-multiplatform repo to core * Move scripts from compose-multiplatform to core * Move fonts from compose multiplatform repo to core * Update scripts to support single core repository setup --------- Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
igordmn
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Move README.md from compose-multiplatform repo to core * Move scripts from compose-multiplatform to core * Move fonts from compose multiplatform repo to core * Update scripts to support single core repository setup --------- Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
This also works around sending an empty test suite to FTL from savedstate-ktx that is currently causing failures. Test: cd navigation && ./gradlew bOS Change-Id: I94764a195b488210fd5af5e11079900ae4cc2a47 This is an imported pull request from androidx#510. Resolves #510 Github-Pr-Head-Sha: 0651b25 GitOrigin-RevId: 8d7dc9c Change-Id: I14d1e8f6132daba6fde82995a1bfb9f01dd30281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: run tasks from newely created :mpp:* gradle project
Issues Fixed
No issues related to the PR