Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Cloud Bigtable dependency to 1.0.0 #808

Closed
wants to merge 1 commit into from

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Dec 8, 2017

Upgrading Cloud Bigtable dependency to 1.0.0. I testing out some basic JanusGraph functionality against Cloud Bigtable, and things seemed to work. The current documentation for Cloud Bigtable will work with this change.

@mbrukman, FYI.

@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@janusgraph-bot janusgraph-bot added the cla: no This PR is not compliant with the CLA label Dec 8, 2017
@amcp
Copy link

amcp commented Dec 8, 2017

@sduskis please submit a CLA with the team.

@mbrukman
Copy link
Member

mbrukman commented Dec 9, 2017

@sduskis will be covered by the Google CCLA; I'll take care of this.

@mbrukman
Copy link
Member

mbrukman commented Dec 9, 2017

@sduskis, thanks for updating the Bigtable version!

Could you please also make the following changes:

  • rebase your PR to the 0.2 branch instead of master and change the branch base at the top of your PR
  • also update docs/versions.adoc to specify the new library version

The 0.2 branch will be periodically merged into master so it will be part of the upcoming 0.3.0 release, but adding it to the 0.2 branch will also make it possible to be included in the 0.2.1 release as well.

@janusgraph-bot janusgraph-bot added cla: yes This PR is compliant with the CLA and removed cla: no This PR is not compliant with the CLA labels Dec 9, 2017
@sduskis sduskis closed this Dec 10, 2017
@mbrukman
Copy link
Member

@sduskis — no need to close this PR just to rebase it on a new branch, you can do that without creating a new branch or PR:

  • rebase your local branch on the 0.2 branch
  • git push -f
  • change the branch selector at the top of the page on GitHub to use 0.2 instead of master

sduskis added a commit to sduskis/janusgraph that referenced this pull request Dec 10, 2017
@mbrukman mbrukman removed this from the Release v0.2.1 milestone Dec 10, 2017
twilmes pushed a commit to twilmes/janusgraph that referenced this pull request Dec 13, 2017
davidclement90 pushed a commit that referenced this pull request Dec 14, 2017
bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019
bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants