Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use localeCompare for sorting #214

Closed
wants to merge 1 commit into from
Closed

fix: use localeCompare for sorting #214

wants to merge 1 commit into from

Conversation

evaliyev
Copy link
Contributor

Description

Update sortAlphabetically to use localeCompare

Justification (Why)

Addresses #206

How Can This Be Tested?

Test were updated

@evaliyev
Copy link
Contributor Author

@JamieMason Please take a look

@JamieMason
Copy link
Owner

Thanks a lot @evaliyev, appreciate it!

JamieMason added a commit that referenced this pull request May 13, 2024
@JamieMason
[WIP] add sorting test examples from #214
9174dd7
@JamieMason
Copy link
Owner

Released in 12.4.0

@evaliyev evaliyev deleted the fix_issue_206 branch September 26, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evaliyev @JamieMason