Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid docs fixed #2

Merged
merged 1 commit into from
May 30, 2022
Merged

invalid docs fixed #2

merged 1 commit into from
May 30, 2022

Conversation

krzysztofrewak
Copy link
Contributor

@krzysztofrewak krzysztofrewak commented May 30, 2022 •
edited
Loading

image

Your static method Xml2Array::convert() returns $this, but the docblock says it's an array. It's bad for static analysis in our projects, so I would like to fix this.

@JackieDo JackieDo merged commit 6e2b4d2 into JackieDo:master May 30, 2022
@JackieDo
Copy link
Owner

@krzysztofrewak:

Thank you so much. Your pull request has been merged and published to version 1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztofrewak @JackieDo