-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kwxm/conformance/two digit test names #6627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
added
Test
Builtins
No Changelog Required
Add this to skip the Changelog Check
Internal
labels
Nov 4, 2024
effectfully
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is much better. How did you do it?
I used shell scripts involving |
This was referenced Nov 12, 2024
v0d1ch
pushed a commit
to v0d1ch/plutus
that referenced
this pull request
Dec 6, 2024
* Rename files to add leading zeros * Fix test case nesting for chooseList and nullList * Fix names of tests excluded from agda-conformance * Fix some bad renamings * Fix some bad renamings * Rename some of the constant tests as well * Rename some of the constant tests as well * More renaming * More renaming for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of the builtins we have conformance tests with names like
case-1
,case-2
, ...case-9
,case-10
,case-11
, .... This is annoying because sometimes they get listed and/or processed in alphanumeric order, not numeric order:case-1
,case-11
,case-12
,case-2
,case-3
, ... . This PR renames all of the files to have two-digit numbers, so we get things in the right order:case-01
,case-02
, ...,case-09
,case-10
,case-11
, ... . This is tedious but it should makes things easier in future. I also tried to make the naming more consistent in general.