Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwxm/conformance/two digit test names #6627

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

kwxm
Copy link
Contributor

@kwxm kwxm commented Nov 4, 2024

For some of the builtins we have conformance tests with names like case-1, case-2, ... case-9, case-10, case-11, .... This is annoying because sometimes they get listed and/or processed in alphanumeric order, not numeric order: case-1, case-11, case-12, case-2, case-3, ... . This PR renames all of the files to have two-digit numbers, so we get things in the right order: case-01, case-02, ..., case-09, case-10, case-11, ... . This is tedious but it should makes things easier in future. I also tried to make the naming more consistent in general.

@kwxm kwxm added Test Builtins No Changelog Required Add this to skip the Changelog Check Internal labels Nov 4, 2024
@kwxm kwxm requested review from ramsay-t and effectfully November 4, 2024 07:02
Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is much better. How did you do it?

@kwxm
Copy link
Contributor Author

kwxm commented Nov 4, 2024

I agree that this is much better. How did you do it?

I used shell scripts involving find and sed along with a lot of git reset --hard when I got it wrong.

@kwxm kwxm removed the request for review from ramsay-t November 4, 2024 13:14
@kwxm kwxm merged commit cfcfe10 into master Nov 4, 2024
8 checks passed
@kwxm kwxm deleted the kwxm/conformance/two-digit-test-names branch November 4, 2024 13:14
v0d1ch pushed a commit to v0d1ch/plutus that referenced this pull request Dec 6, 2024
* Rename files to add leading zeros

* Fix test case nesting for chooseList and nullList

* Fix names of tests excluded from agda-conformance

* Fix some bad renamings

* Fix some bad renamings

* Rename some of the constant tests as well

* Rename some of the constant tests as well

* More renaming

* More renaming for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builtins Internal No Changelog Required Add this to skip the Changelog Check Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants