-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.2.0.0 #5166
Version 1.2.0.0 #5166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add CHANGELOG.md
to extra-doc-files
for the packages that now have a changelog.
scripts/prepare-release.sh
Outdated
@@ -19,6 +19,7 @@ shift | |||
|
|||
default_packages=( | |||
"plutus-core" | |||
"plutus-ir" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see the problem. The problem is that I didn't use the qualified notation for adding the plutus-ir
dependencies, so the script isn't updating them. I think the right fix is instead to use plutus-core:plutus-ir
instead of plutus-ir
; the script handles that. OR to just omit the version bound when depending on plutus-ir
from inside plutus-core
, which is what we mostly do elsewhere when depending on components inside the current package (since the version bound does nothing in that case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you'd written a comment about the problem I wouldn't have had to reverse-engineer it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I didn't realize we can write plutus-core:plutus-ir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the simplest thing would be to remove the version bounds from the internal deps in plutus-core
: we have the same problem with e.g. plutus-core-testlib
being used without the plutus-core:
and with a version bound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fortunately plutus-core-testlib
starts with plutus-core
😂
The thing is the script will add the version bounds back, so the script will need to be modified. I'll do that separately - don't want it to block the release
a859381
to
d52fbe7
Compare
I considered tagging 1.2.0.0 from the commit where we started enforcing changelogs.
However, it would be inconvenient because I'd have to add a few commits on top of that, and backport them to master.
Also, by then we had already had a few changelog entries anyway.
So I'm tagging 1.2.0.0 from master. The changelog won't be exhaustive for this release, but will be for future releases.