[Builtins] Inline SatInt stuff and costing monoids
#5062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
Performance
Costing
effectfully
commented
Jan 22, 2023
Comment on lines
118
to
122
| {-# INLINE succ #-} | ||
| succ = coerce (succ :: Int -> Int) | ||
|
|
||
| {-# INLINE pred #-} | ||
| pred = coerce (pred :: Int -> Int) |
There was a problem hiding this comment.
@michaelpj we still have this bug.
effectfully
commented
Jan 22, 2023
Comment on lines
88
to
91
| {-# INLINE abs #-} | ||
| abs x | ||
| | x >= 0 = x | ||
| | otherwise = negate x | ||
| signum (SI x) = SI (signum x) | ||
| | x >= 0 = x | ||
| | otherwise = negate x |
There was a problem hiding this comment.
Why is it a custom definition? How does it handle near-maximum values? Needs a few tests at the very least (unless they're already in place).
There was a problem hiding this comment.
Basically this stuff all got copied from safeint... which sadly means I don't have good justifications for a bunch of things :/
There was a problem hiding this comment.
I remember thinking at the time that we should dump everything from safeInt except for the few things we actually need.
There was a problem hiding this comment.
I've checked it and I think the current behavior is as correct as the default one:
>>> (minBound :: SatInt, negate (minBound :: SatInt))
(-9223372036854775808,9223372036854775807)
>>> (minBound :: SatInt, 0 - minBound :: SatInt)
(-9223372036854775808,9223372036854775807)
>>> (maxBound :: SatInt, negate (maxBound :: SatInt))
(9223372036854775807,-9223372036854775807)
>>> (maxBound :: SatInt, 0 - maxBound :: SatInt)
(9223372036854775807,-9223372036854775807)
Maybe it's a custom definition to make it faster or clearer.
Would still be great to have such tests if they're not there.
|
/benchmark validation |
|
^ Just experimenting to see if running the benchmarks here uses the same machine that we use manually. Looks like they do. I've cancelled the benchmarking job now. |
effectfully
force-pushed
the
effectfully/builtins/inline-costing-monoids
branch
from
4c25a04 to
f999659
Compare
|
/benchmark plutus-benchmark:validation |
1 similar comment
|
/benchmark plutus-benchmark:validation |
|
Click here to check the status of your benchmark. |
1 similar comment
|
Click here to check the status of your benchmark. |
effectfully
force-pushed
the
effectfully/builtins/inline-costing-monoids
branch
from
f999659 to
aa0995c
Compare
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of ' validation' on 'bb6e4ff75' (base) and 'aa0995cdc' (PR) Results table
|
effectfully
force-pushed
the
effectfully/builtins/inline-costing-monoids
branch
from
aa0995c to
58b360e
Compare
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of ' validation' on 'bb6e4ff75' (base) and '58b360e71' (PR) Results table
|
effectfully
force-pushed
the
effectfully/builtins/inline-costing-monoids
branch
from
0091d3c to
8d7623b
Compare
effectfully
force-pushed
the
effectfully/builtins/inline-costing-monoids
branch
from
8d7623b to
232713f
Compare
|
/benchmark validation |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of ' validation' on 'bb6e4ff75' (base) and '232713f32' (PR) Results table
|
|
/benchmark nofib |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of ' nofib' on 'bb6e4ff75' (base) and '232713f32' (PR) Results table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I noticed in the Core, needs benchmarking, so don't look here yet.