Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Builtins] Disallow builtins with type arguments appearing last #4616

Closed
wants to merge 7 commits into from
Closed

[Builtins] Disallow builtins with type arguments appearing last #4616

wants to merge 7 commits into from

Conversation

effectfully
Copy link
Contributor

@effectfully effectfully commented May 13, 2022 •
edited
Loading

Don't look here yet.

@effectfully effectfully marked this pull request as draft May 13, 2022 14:16
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@effectfully effectfully changed the title Effectfully/builtins/no eval builtin app and no types appearing last [Builtins] Disallow builtins with type arguments appearing last May 13, 2022
@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '4af22f9fb' (base) and '7e53af3b0' (PR)

Results table
Script 4af22f9 7e53af3 Change
auction_1-1 224.6 μs 197.5 μs -12.1%
auction_1-2 845.6 μs 813.3 μs -3.8%
auction_1-3 837.0 μs 803.3 μs -4.0%
auction_1-4 291.3 μs 252.8 μs -13.2%
auction_2-1 225.5 μs 198.9 μs -11.8%
auction_2-2 841.8 μs 814.6 μs -3.2%
auction_2-3 1.072 ms 1.036 ms -3.4%
auction_2-4 836.6 μs 802.1 μs -4.1%
auction_2-5 292.0 μs 252.3 μs -13.6%
crowdfunding-success-1 266.9 μs 232.1 μs -13.0%
crowdfunding-success-2 266.1 μs 232.0 μs -12.8%
crowdfunding-success-3 266.3 μs 232.8 μs -12.6%
currency-1 317.4 μs 300.9 μs -5.2%
escrow-redeem_1-1 459.9 μs 425.0 μs -7.6%
escrow-redeem_1-2 459.6 μs 424.4 μs -7.7%
escrow-redeem_2-1 542.2 μs 499.9 μs -7.8%
escrow-redeem_2-2 542.6 μs 498.6 μs -8.1%
escrow-redeem_2-3 542.1 μs 498.2 μs -8.1%
escrow-refund-1 200.9 μs 174.5 μs -13.1%
future-increase-margin-1 318.0 μs 298.9 μs -6.0%
future-increase-margin-2 718.7 μs 671.5 μs -6.6%
future-increase-margin-3 718.4 μs 672.6 μs -6.4%
future-increase-margin-4 669.4 μs 630.8 μs -5.8%
future-increase-margin-5 1.037 ms 1.007 ms -2.9%
future-pay-out-1 318.1 μs 299.0 μs -6.0%
future-pay-out-2 716.0 μs 673.4 μs -5.9%
future-pay-out-3 717.4 μs 674.7 μs -6.0%
future-pay-out-4 1.042 ms 1.002 ms -3.8%
future-settle-early-1 318.4 μs 298.6 μs -6.2%
future-settle-early-2 716.0 μs 670.3 μs -6.4%
future-settle-early-3 715.8 μs 673.5 μs -5.9%
future-settle-early-4 797.3 μs 762.8 μs -4.3%
game-sm-success_1-1 522.8 μs 479.0 μs -8.4%
game-sm-success_1-2 250.8 μs 217.3 μs -13.4%
game-sm-success_1-3 845.4 μs 804.4 μs -4.8%
game-sm-success_1-4 291.1 μs 253.3 μs -13.0%
game-sm-success_2-1 520.3 μs 482.1 μs -7.3%
game-sm-success_2-2 250.4 μs 217.3 μs -13.2%
game-sm-success_2-3 841.3 μs 803.4 μs -4.5%
game-sm-success_2-4 290.3 μs 253.5 μs -12.7%
game-sm-success_2-5 844.1 μs 800.6 μs -5.2%
game-sm-success_2-6 291.0 μs 253.5 μs -12.9%
multisig-sm-1 533.9 μs 502.1 μs -6.0%
multisig-sm-2 521.0 μs 487.1 μs -6.5%
multisig-sm-3 525.9 μs 494.0 μs -6.1%
multisig-sm-4 532.9 μs 498.6 μs -6.4%
multisig-sm-5 746.9 μs 714.7 μs -4.3%
multisig-sm-6 531.8 μs 499.0 μs -6.2%
multisig-sm-7 521.1 μs 485.4 μs -6.9%
multisig-sm-8 527.9 μs 491.9 μs -6.8%
multisig-sm-9 536.0 μs 498.0 μs -7.1%
multisig-sm-10 752.1 μs 715.2 μs -4.9%
ping-pong-1 440.3 μs 408.4 μs -7.2%
ping-pong-2 439.3 μs 408.5 μs -7.0%
ping-pong_2-1 261.3 μs 237.9 μs -9.0%
prism-1 207.9 μs 181.3 μs -12.8%
prism-2 563.2 μs 520.6 μs -7.6%
prism-3 478.3 μs 436.7 μs -8.7%
pubkey-1 177.1 μs 153.0 μs -13.6%
stablecoin_1-1 1.174 ms 1.111 ms -5.4%
stablecoin_1-2 243.5 μs 211.8 μs -13.0%
stablecoin_1-3 1.345 ms 1.265 ms -5.9%
stablecoin_1-4 259.3 μs 225.5 μs -13.0%
stablecoin_1-5 1.708 ms 1.593 ms -6.7%
stablecoin_1-6 321.2 μs 279.1 μs -13.1%
stablecoin_2-1 1.175 ms 1.111 ms -5.4%
stablecoin_2-2 243.6 μs 211.7 μs -13.1%
stablecoin_2-3 1.345 ms 1.267 ms -5.8%
stablecoin_2-4 259.2 μs 225.7 μs -12.9%
token-account-1 241.1 μs 221.9 μs -8.0%
token-account-2 430.2 μs 398.5 μs -7.4%
uniswap-1 535.2 μs 513.7 μs -4.0%
uniswap-2 283.2 μs 260.6 μs -8.0%
uniswap-3 2.188 ms 2.050 ms -6.3%
uniswap-4 426.3 μs 372.2 μs -12.7%
uniswap-5 1.505 ms 1.397 ms -7.2%
uniswap-6 409.1 μs 358.0 μs -12.5%
vesting-1 455.1 μs 428.3 μs -5.9%

@effectfully
Copy link
Contributor Author

Same -8% as with Lazy living in the Runtime module, so I don't see why we'd want to limit expressiveness with more code for nothing.

@effectfully effectfully deleted the effectfully/builtins/no-evalBuiltinApp-and-no-types-appearing-last branch May 17, 2022 23:08
@effectfully effectfully mentioned this pull request May 18, 2022
Closed
@effectfully effectfully mentioned this pull request Jun 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Builtins Evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @iohk-devops