Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Builtins] Drop 'val' from 'KnownType' stuff #4533

Closed
wants to merge 6 commits into from
Closed

[Builtins] Drop 'val' from 'KnownType' stuff #4533

wants to merge 6 commits into from

Conversation

effectfully
Copy link
Contributor

Same as #4499, except the history is correct.

@effectfully effectfully force-pushed the effectfully/builtins/drop-val-from-KnownType-stuff-2 branch from b3f98c8 to f494b1c Compare April 12, 2022 23:28
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'b30008f5d' (base) and 'f494b1c88' (PR)

Results table
Script b30008f f494b1c Change
auction_1-1 204.9 μs 205.7 μs +0.4%
auction_1-2 819.7 μs 826.0 μs +0.8%
auction_1-3 808.5 μs 814.0 μs +0.7%
auction_1-4 260.3 μs 265.1 μs +1.8%
auction_2-1 204.9 μs 206.1 μs +0.6%
auction_2-2 817.4 μs 824.7 μs +0.9%
auction_2-3 1.034 ms 1.049 ms +1.5%
auction_2-4 804.2 μs 812.2 μs +1.0%
auction_2-5 259.0 μs 265.5 μs +2.5%
crowdfunding-success-1 240.7 μs 244.2 μs +1.5%
crowdfunding-success-2 239.8 μs 244.1 μs +1.8%
crowdfunding-success-3 240.9 μs 243.5 μs +1.1%
currency-1 301.7 μs 303.4 μs +0.6%
escrow-redeem_1-1 427.5 μs 434.2 μs +1.6%
escrow-redeem_1-2 426.8 μs 434.1 μs +1.7%
escrow-redeem_2-1 502.2 μs 510.0 μs +1.6%
escrow-redeem_2-2 502.7 μs 511.0 μs +1.7%
escrow-redeem_2-3 504.1 μs 509.4 μs +1.1%
escrow-refund-1 182.1 μs 184.4 μs +1.3%
future-increase-margin-1 302.3 μs 302.0 μs -0.1%
future-increase-margin-2 680.1 μs 683.9 μs +0.6%
future-increase-margin-3 680.9 μs 685.7 μs +0.7%
future-increase-margin-4 637.0 μs 640.1 μs +0.5%
future-increase-margin-5 1.011 ms 1.019 ms +0.8%
future-pay-out-1 300.6 μs 302.3 μs +0.6%
future-pay-out-2 678.2 μs 685.4 μs +1.1%
future-pay-out-3 678.8 μs 683.5 μs +0.7%
future-pay-out-4 1.010 ms 1.012 ms +0.2%
future-settle-early-1 299.7 μs 303.0 μs +1.1%
future-settle-early-2 679.2 μs 688.4 μs +1.4%
future-settle-early-3 678.8 μs 689.3 μs +1.5%
future-settle-early-4 769.6 μs 775.7 μs +0.8%
game-sm-success_1-1 486.3 μs 489.8 μs +0.7%
game-sm-success_1-2 221.7 μs 226.3 μs +2.1%
game-sm-success_1-3 801.5 μs 811.1 μs +1.2%
game-sm-success_1-4 258.5 μs 263.3 μs +1.9%
game-sm-success_2-1 488.0 μs 488.1 μs +0.0%
game-sm-success_2-2 223.1 μs 225.6 μs +1.1%
game-sm-success_2-3 805.8 μs 813.2 μs +0.9%
game-sm-success_2-4 258.2 μs 263.1 μs +1.9%
game-sm-success_2-5 806.0 μs 810.4 μs +0.5%
game-sm-success_2-6 257.9 μs 263.8 μs +2.3%
multisig-sm-1 503.5 μs 506.8 μs +0.7%
multisig-sm-2 489.9 μs 496.2 μs +1.3%
multisig-sm-3 496.6 μs 500.7 μs +0.8%
multisig-sm-4 500.0 μs 507.3 μs +1.5%
multisig-sm-5 718.7 μs 725.2 μs +0.9%
multisig-sm-6 504.4 μs 510.1 μs +1.1%
multisig-sm-7 492.2 μs 496.2 μs +0.8%
multisig-sm-8 496.3 μs 500.8 μs +0.9%
multisig-sm-9 500.9 μs 507.1 μs +1.2%
multisig-sm-10 718.1 μs 724.3 μs +0.9%
ping-pong-1 409.3 μs 414.6 μs +1.3%
ping-pong-2 409.3 μs 414.6 μs +1.3%
ping-pong_2-1 241.1 μs 243.5 μs +1.0%
prism-1 184.9 μs 187.1 μs +1.2%
prism-2 526.8 μs 528.4 μs +0.3%
prism-3 441.9 μs 444.3 μs +0.5%
pubkey-1 156.3 μs 156.8 μs +0.3%
stablecoin_1-1 1.122 ms 1.124 ms +0.2%
stablecoin_1-2 218.6 μs 221.9 μs +1.5%
stablecoin_1-3 1.279 ms 1.283 ms +0.3%
stablecoin_1-4 231.4 μs 234.8 μs +1.5%
stablecoin_1-5 1.605 ms 1.602 ms -0.2%
stablecoin_1-6 285.6 μs 290.4 μs +1.7%
stablecoin_2-1 1.117 ms 1.121 ms +0.4%
stablecoin_2-2 217.2 μs 221.1 μs +1.8%
stablecoin_2-3 1.276 ms 1.281 ms +0.4%
stablecoin_2-4 231.2 μs 235.5 μs +1.9%
token-account-1 225.0 μs 228.0 μs +1.3%
token-account-2 397.8 μs 407.2 μs +2.4%
uniswap-1 508.7 μs 510.7 μs +0.4%
uniswap-2 265.0 μs 267.3 μs +0.9%
uniswap-3 2.050 ms 2.070 ms +1.0%
uniswap-4 380.8 μs 386.3 μs +1.4%
uniswap-5 1.402 ms 1.413 ms +0.8%
uniswap-6 366.6 μs 370.8 μs +1.1%
vesting-1 431.1 μs 434.4 μs +0.8%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'b30008f5d' (base) and '90305a8cf' (PR)

Results table
Script b30008f 90305a8 Change
auction_1-1 203.6 μs 205.7 μs +1.0%
auction_1-2 818.8 μs 828.0 μs +1.1%
auction_1-3 809.2 μs 817.8 μs +1.1%
auction_1-4 260.5 μs 266.7 μs +2.4%
auction_2-1 205.3 μs 207.2 μs +0.9%
auction_2-2 817.5 μs 829.4 μs +1.5%
auction_2-3 1.032 ms 1.055 ms +2.2%
auction_2-4 805.2 μs 816.7 μs +1.4%
auction_2-5 258.3 μs 266.3 μs +3.1%
crowdfunding-success-1 239.4 μs 241.3 μs +0.8%
crowdfunding-success-2 239.3 μs 241.4 μs +0.9%
crowdfunding-success-3 240.0 μs 241.4 μs +0.6%
currency-1 300.2 μs 304.2 μs +1.3%
escrow-redeem_1-1 428.2 μs 435.8 μs +1.8%
escrow-redeem_1-2 427.8 μs 436.7 μs +2.1%
escrow-redeem_2-1 503.3 μs 512.5 μs +1.8%
escrow-redeem_2-2 502.2 μs 511.7 μs +1.9%
escrow-redeem_2-3 501.8 μs 511.7 μs +2.0%
escrow-refund-1 181.2 μs 183.9 μs +1.5%
future-increase-margin-1 301.0 μs 303.4 μs +0.8%
future-increase-margin-2 679.0 μs 688.8 μs +1.4%
future-increase-margin-3 681.6 μs 688.5 μs +1.0%
future-increase-margin-4 637.9 μs 640.2 μs +0.4%
future-increase-margin-5 1.010 ms 1.017 ms +0.7%
future-pay-out-1 301.1 μs 304.8 μs +1.2%
future-pay-out-2 679.4 μs 690.5 μs +1.6%
future-pay-out-3 678.1 μs 691.0 μs +1.9%
future-pay-out-4 1.009 ms 1.017 ms +0.8%
future-settle-early-1 300.8 μs 303.8 μs +1.0%
future-settle-early-2 677.8 μs 690.1 μs +1.8%
future-settle-early-3 677.0 μs 691.5 μs +2.1%
future-settle-early-4 766.9 μs 780.0 μs +1.7%
game-sm-success_1-1 485.0 μs 493.4 μs +1.7%
game-sm-success_1-2 221.6 μs 225.3 μs +1.7%
game-sm-success_1-3 803.6 μs 816.7 μs +1.6%
game-sm-success_1-4 257.5 μs 263.2 μs +2.2%
game-sm-success_2-1 485.0 μs 492.7 μs +1.6%
game-sm-success_2-2 222.1 μs 224.6 μs +1.1%
game-sm-success_2-3 803.3 μs 813.0 μs +1.2%
game-sm-success_2-4 258.6 μs 262.9 μs +1.7%
game-sm-success_2-5 803.8 μs 813.0 μs +1.1%
game-sm-success_2-6 258.4 μs 263.0 μs +1.8%
multisig-sm-1 502.8 μs 508.5 μs +1.1%
multisig-sm-2 489.0 μs 495.6 μs +1.3%
multisig-sm-3 495.0 μs 501.6 μs +1.3%
multisig-sm-4 500.9 μs 507.2 μs +1.3%
multisig-sm-5 716.3 μs 722.9 μs +0.9%
multisig-sm-6 500.4 μs 507.0 μs +1.3%
multisig-sm-7 488.1 μs 496.2 μs +1.7%
multisig-sm-8 494.4 μs 503.1 μs +1.8%
multisig-sm-9 498.5 μs 510.1 μs +2.3%
multisig-sm-10 717.0 μs 729.7 μs +1.8%
ping-pong-1 409.8 μs 417.2 μs +1.8%
ping-pong-2 409.9 μs 416.5 μs +1.6%
ping-pong_2-1 240.5 μs 244.7 μs +1.7%
prism-1 184.2 μs 186.6 μs +1.3%
prism-2 522.9 μs 530.5 μs +1.5%
prism-3 438.1 μs 445.5 μs +1.7%
pubkey-1 155.8 μs 156.1 μs +0.2%
stablecoin_1-1 1.117 ms 1.127 ms +0.9%
stablecoin_1-2 217.7 μs 220.5 μs +1.3%
stablecoin_1-3 1.278 ms 1.283 ms +0.4%
stablecoin_1-4 230.4 μs 234.4 μs +1.7%
stablecoin_1-5 1.601 ms 1.615 ms +0.9%
stablecoin_1-6 286.2 μs 290.7 μs +1.6%
stablecoin_2-1 1.122 ms 1.124 ms +0.2%
stablecoin_2-2 217.6 μs 219.9 μs +1.1%
stablecoin_2-3 1.274 ms 1.284 ms +0.8%
stablecoin_2-4 230.6 μs 234.4 μs +1.6%
token-account-1 225.4 μs 228.1 μs +1.2%
token-account-2 399.1 μs 408.0 μs +2.2%
uniswap-1 508.7 μs 518.6 μs +1.9%
uniswap-2 264.4 μs 268.1 μs +1.4%
uniswap-3 2.041 ms 2.085 ms +2.2%
uniswap-4 380.4 μs 387.2 μs +1.8%
uniswap-5 1.395 ms 1.425 ms +2.2%
uniswap-6 365.9 μs 371.4 μs +1.5%
vesting-1 432.1 μs 435.7 μs +0.8%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'b30008f5d' (base) and '264812fbf' (PR)

Results table
Script b30008f 264812f Change
auction_1-1 203.9 μs 209.1 μs +2.6%
auction_1-2 813.3 μs 826.9 μs +1.7%
auction_1-3 803.5 μs 815.5 μs +1.5%
auction_1-4 259.7 μs 265.6 μs +2.3%
auction_2-1 205.2 μs 208.2 μs +1.5%
auction_2-2 816.3 μs 826.5 μs +1.2%
auction_2-3 1.032 ms 1.045 ms +1.3%
auction_2-4 801.7 μs 814.3 μs +1.6%
auction_2-5 260.8 μs 265.3 μs +1.7%
crowdfunding-success-1 241.0 μs 244.6 μs +1.5%
crowdfunding-success-2 241.5 μs 245.4 μs +1.6%
crowdfunding-success-3 242.2 μs 244.8 μs +1.1%
currency-1 302.2 μs 305.1 μs +1.0%
escrow-redeem_1-1 429.1 μs 432.6 μs +0.8%
escrow-redeem_1-2 428.2 μs 432.9 μs +1.1%
escrow-redeem_2-1 504.5 μs 509.4 μs +1.0%
escrow-redeem_2-2 502.7 μs 509.0 μs +1.3%
escrow-redeem_2-3 503.1 μs 509.7 μs +1.3%
escrow-refund-1 181.4 μs 185.2 μs +2.1%
future-increase-margin-1 300.4 μs 306.3 μs +2.0%
future-increase-margin-2 676.7 μs 690.1 μs +2.0%
future-increase-margin-3 676.5 μs 688.7 μs +1.8%
future-increase-margin-4 636.7 μs 642.6 μs +0.9%
future-increase-margin-5 1.011 ms 1.022 ms +1.1%
future-pay-out-1 300.9 μs 305.3 μs +1.5%
future-pay-out-2 676.9 μs 686.3 μs +1.4%
future-pay-out-3 677.9 μs 686.0 μs +1.2%
future-pay-out-4 1.006 ms 1.019 ms +1.3%
future-settle-early-1 299.6 μs 304.1 μs +1.5%
future-settle-early-2 679.5 μs 684.6 μs +0.8%
future-settle-early-3 680.1 μs 687.8 μs +1.1%
future-settle-early-4 773.1 μs 776.3 μs +0.4%
game-sm-success_1-1 488.7 μs 491.7 μs +0.6%
game-sm-success_1-2 223.7 μs 226.0 μs +1.0%
game-sm-success_1-3 807.0 μs 812.7 μs +0.7%
game-sm-success_1-4 259.1 μs 263.6 μs +1.7%
game-sm-success_2-1 486.6 μs 492.7 μs +1.3%
game-sm-success_2-2 223.0 μs 228.3 μs +2.4%
game-sm-success_2-3 802.2 μs 817.8 μs +1.9%
game-sm-success_2-4 260.6 μs 265.0 μs +1.7%
game-sm-success_2-5 805.6 μs 816.5 μs +1.4%
game-sm-success_2-6 259.9 μs 264.8 μs +1.9%
multisig-sm-1 503.9 μs 508.6 μs +0.9%
multisig-sm-2 490.5 μs 495.9 μs +1.1%
multisig-sm-3 499.1 μs 501.3 μs +0.4%
multisig-sm-4 504.2 μs 506.6 μs +0.5%
multisig-sm-5 724.2 μs 726.0 μs +0.2%
multisig-sm-6 503.9 μs 507.3 μs +0.7%
multisig-sm-7 492.3 μs 494.0 μs +0.3%
multisig-sm-8 497.5 μs 500.0 μs +0.5%
multisig-sm-9 501.4 μs 504.9 μs +0.7%
multisig-sm-10 719.8 μs 725.8 μs +0.8%
ping-pong-1 410.4 μs 415.1 μs +1.1%
ping-pong-2 410.8 μs 415.1 μs +1.0%
ping-pong_2-1 241.3 μs 243.6 μs +1.0%
prism-1 184.8 μs 187.7 μs +1.6%
prism-2 523.7 μs 529.9 μs +1.2%
prism-3 439.9 μs 445.1 μs +1.2%
pubkey-1 156.5 μs 158.9 μs +1.5%
stablecoin_1-1 1.118 ms 1.126 ms +0.7%
stablecoin_1-2 218.4 μs 223.6 μs +2.4%
stablecoin_1-3 1.278 ms 1.292 ms +1.1%
stablecoin_1-4 232.3 μs 236.5 μs +1.8%
stablecoin_1-5 1.594 ms 1.614 ms +1.3%
stablecoin_1-6 286.0 μs 293.0 μs +2.4%
stablecoin_2-1 1.115 ms 1.129 ms +1.3%
stablecoin_2-2 218.0 μs 223.1 μs +2.3%
stablecoin_2-3 1.285 ms 1.284 ms -0.1%
stablecoin_2-4 231.4 μs 235.1 μs +1.6%
token-account-1 227.0 μs 226.4 μs -0.3%
token-account-2 400.9 μs 405.8 μs +1.2%
uniswap-1 508.3 μs 515.7 μs +1.5%
uniswap-2 266.1 μs 267.8 μs +0.6%
uniswap-3 2.045 ms 2.064 ms +0.9%
uniswap-4 383.3 μs 389.2 μs +1.5%
uniswap-5 1.407 ms 1.422 ms +1.1%
uniswap-6 368.1 μs 374.3 μs +1.7%
vesting-1 431.4 μs 438.2 μs +1.6%

@effectfully effectfully force-pushed the effectfully/builtins/drop-val-from-KnownType-stuff-2 branch from 264812f to 7e958cc Compare April 13, 2022 14:48
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '65b2c34d5' (base) and '8c3edb62c' (PR)

Results table
Script 65b2c34 8c3edb6 Change
auction_1-1 203.4 μs 205.2 μs +0.9%
auction_1-2 815.6 μs 821.7 μs +0.7%
auction_1-3 807.4 μs 811.3 μs +0.5%
auction_1-4 259.9 μs 260.5 μs +0.2%
auction_2-1 205.4 μs 205.8 μs +0.2%
auction_2-2 816.8 μs 823.8 μs +0.9%
auction_2-3 1.031 ms 1.045 ms +1.4%
auction_2-4 808.3 μs 812.7 μs +0.5%
auction_2-5 260.3 μs 262.2 μs +0.7%
crowdfunding-success-1 241.5 μs 242.0 μs +0.2%
crowdfunding-success-2 240.7 μs 240.7 μs 0.0%
crowdfunding-success-3 240.5 μs 241.0 μs +0.2%
currency-1 301.6 μs 300.9 μs -0.2%
escrow-redeem_1-1 428.7 μs 429.1 μs +0.1%
escrow-redeem_1-2 429.0 μs 430.9 μs +0.4%
escrow-redeem_2-1 502.9 μs 506.4 μs +0.7%
escrow-redeem_2-2 502.3 μs 504.3 μs +0.4%
escrow-redeem_2-3 502.9 μs 505.1 μs +0.4%
escrow-refund-1 180.6 μs 181.6 μs +0.6%
future-increase-margin-1 299.0 μs 300.8 μs +0.6%
future-increase-margin-2 676.3 μs 681.9 μs +0.8%
future-increase-margin-3 678.2 μs 683.3 μs +0.8%
future-increase-margin-4 635.3 μs 638.2 μs +0.5%
future-increase-margin-5 1.006 ms 1.013 ms +0.7%
future-pay-out-1 299.5 μs 300.4 μs +0.3%
future-pay-out-2 677.3 μs 684.0 μs +1.0%
future-pay-out-3 677.3 μs 686.2 μs +1.3%
future-pay-out-4 1.004 ms 1.020 ms +1.6%
future-settle-early-1 300.3 μs 302.0 μs +0.6%
future-settle-early-2 680.7 μs 686.5 μs +0.9%
future-settle-early-3 677.9 μs 686.4 μs +1.3%
future-settle-early-4 767.3 μs 774.0 μs +0.9%
game-sm-success_1-1 485.7 μs 487.4 μs +0.4%
game-sm-success_1-2 223.8 μs 222.4 μs -0.6%
game-sm-success_1-3 805.3 μs 806.9 μs +0.2%
game-sm-success_1-4 258.7 μs 258.7 μs 0.0%
game-sm-success_2-1 484.0 μs 489.2 μs +1.1%
game-sm-success_2-2 222.5 μs 222.5 μs 0.0%
game-sm-success_2-3 800.9 μs 809.2 μs +1.0%
game-sm-success_2-4 259.4 μs 259.0 μs -0.2%
game-sm-success_2-5 804.0 μs 812.5 μs +1.1%
game-sm-success_2-6 259.6 μs 260.6 μs +0.4%
multisig-sm-1 500.8 μs 505.9 μs +1.0%
multisig-sm-2 486.7 μs 493.4 μs +1.4%
multisig-sm-3 493.5 μs 499.4 μs +1.2%
multisig-sm-4 498.9 μs 504.9 μs +1.2%
multisig-sm-5 717.0 μs 725.1 μs +1.1%
multisig-sm-6 500.9 μs 505.4 μs +0.9%
multisig-sm-7 489.8 μs 491.8 μs +0.4%
multisig-sm-8 495.7 μs 497.5 μs +0.4%
multisig-sm-9 498.4 μs 502.6 μs +0.8%
multisig-sm-10 716.7 μs 721.9 μs +0.7%
ping-pong-1 409.1 μs 411.7 μs +0.6%
ping-pong-2 408.3 μs 411.5 μs +0.8%
ping-pong_2-1 240.3 μs 242.1 μs +0.7%
prism-1 184.5 μs 186.3 μs +1.0%
prism-2 522.4 μs 527.3 μs +0.9%
prism-3 440.8 μs 445.0 μs +1.0%
pubkey-1 156.3 μs 157.0 μs +0.4%
stablecoin_1-1 1.111 ms 1.117 ms +0.5%
stablecoin_1-2 218.1 μs 218.8 μs +0.3%
stablecoin_1-3 1.269 ms 1.276 ms +0.6%
stablecoin_1-4 231.6 μs 232.0 μs +0.2%
stablecoin_1-5 1.589 ms 1.599 ms +0.6%
stablecoin_1-6 286.2 μs 288.3 μs +0.7%
stablecoin_2-1 1.114 ms 1.123 ms +0.8%
stablecoin_2-2 219.4 μs 220.1 μs +0.3%
stablecoin_2-3 1.274 ms 1.281 ms +0.5%
stablecoin_2-4 232.8 μs 232.7 μs -0.0%
token-account-1 224.7 μs 225.7 μs +0.4%
token-account-2 399.3 μs 400.6 μs +0.3%
uniswap-1 508.4 μs 508.2 μs -0.0%
uniswap-2 265.2 μs 265.1 μs -0.0%
uniswap-3 2.044 ms 2.052 ms +0.4%
uniswap-4 383.5 μs 383.5 μs 0.0%
uniswap-5 1.401 ms 1.408 ms +0.5%
uniswap-6 367.5 μs 369.8 μs +0.6%
vesting-1 430.1 μs 435.5 μs +1.3%

@effectfully effectfully force-pushed the effectfully/builtins/drop-val-from-KnownType-stuff-2 branch from e175fd5 to c721203 Compare April 13, 2022 16:16
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

1 similar comment
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '65b2c34d5' (base) and 'c00a346c6' (PR)

Results table
Script 65b2c34 c00a346 Change
auction_1-1 203.4 μs 206.3 μs +1.4%
auction_1-2 816.2 μs 823.2 μs +0.9%
auction_1-3 804.0 μs 811.0 μs +0.9%
auction_1-4 258.7 μs 261.9 μs +1.2%
auction_2-1 204.6 μs 207.0 μs +1.2%
auction_2-2 816.6 μs 823.0 μs +0.8%
auction_2-3 1.032 ms 1.040 ms +0.8%
auction_2-4 804.0 μs 811.1 μs +0.9%
auction_2-5 259.7 μs 262.3 μs +1.0%
crowdfunding-success-1 240.5 μs 242.9 μs +1.0%
crowdfunding-success-2 240.2 μs 242.9 μs +1.1%
crowdfunding-success-3 241.5 μs 243.3 μs +0.7%
currency-1 302.1 μs 304.0 μs +0.6%
escrow-redeem_1-1 429.4 μs 433.8 μs +1.0%
escrow-redeem_1-2 428.4 μs 433.7 μs +1.2%
escrow-redeem_2-1 502.1 μs 511.4 μs +1.9%
escrow-redeem_2-2 502.4 μs 510.3 μs +1.6%
escrow-redeem_2-3 502.9 μs 509.5 μs +1.3%
escrow-refund-1 180.7 μs 183.7 μs +1.7%
future-increase-margin-1 300.2 μs 302.4 μs +0.7%
future-increase-margin-2 678.2 μs 684.5 μs +0.9%
future-increase-margin-3 677.7 μs 684.5 μs +1.0%
future-increase-margin-4 636.5 μs 639.5 μs +0.5%
future-increase-margin-5 1.008 ms 1.018 ms +1.0%
future-pay-out-1 300.5 μs 302.8 μs +0.8%
future-pay-out-2 677.2 μs 684.4 μs +1.1%
future-pay-out-3 676.2 μs 683.6 μs +1.1%
future-pay-out-4 1.002 ms 1.016 ms +1.4%
future-settle-early-1 298.9 μs 302.3 μs +1.1%
future-settle-early-2 677.4 μs 687.6 μs +1.5%
future-settle-early-3 678.0 μs 687.6 μs +1.4%
future-settle-early-4 767.5 μs 778.6 μs +1.4%
game-sm-success_1-1 486.9 μs 490.8 μs +0.8%
game-sm-success_1-2 223.7 μs 226.4 μs +1.2%
game-sm-success_1-3 806.0 μs 810.2 μs +0.5%
game-sm-success_1-4 259.2 μs 261.9 μs +1.0%
game-sm-success_2-1 485.3 μs 487.8 μs +0.5%
game-sm-success_2-2 221.8 μs 225.0 μs +1.4%
game-sm-success_2-3 802.8 μs 807.1 μs +0.5%
game-sm-success_2-4 258.6 μs 261.8 μs +1.2%
game-sm-success_2-5 803.3 μs 805.2 μs +0.2%
game-sm-success_2-6 260.0 μs 260.9 μs +0.3%
multisig-sm-1 501.6 μs 505.5 μs +0.8%
multisig-sm-2 488.2 μs 495.8 μs +1.6%
multisig-sm-3 493.9 μs 500.8 μs +1.4%
multisig-sm-4 498.0 μs 505.9 μs +1.6%
multisig-sm-5 719.3 μs 724.2 μs +0.7%
multisig-sm-6 502.3 μs 506.5 μs +0.8%
multisig-sm-7 490.0 μs 493.2 μs +0.7%
multisig-sm-8 495.8 μs 500.1 μs +0.9%
multisig-sm-9 500.9 μs 504.4 μs +0.7%
multisig-sm-10 718.9 μs 722.9 μs +0.6%
ping-pong-1 410.6 μs 414.3 μs +0.9%
ping-pong-2 409.7 μs 414.3 μs +1.1%
ping-pong_2-1 241.1 μs 243.4 μs +1.0%
prism-1 185.4 μs 187.4 μs +1.1%
prism-2 520.6 μs 527.0 μs +1.2%
prism-3 438.3 μs 442.0 μs +0.8%
pubkey-1 155.8 μs 158.3 μs +1.6%
stablecoin_1-1 1.116 ms 1.122 ms +0.5%
stablecoin_1-2 217.8 μs 221.3 μs +1.6%
stablecoin_1-3 1.272 ms 1.283 ms +0.9%
stablecoin_1-4 230.6 μs 234.0 μs +1.5%
stablecoin_1-5 1.590 ms 1.602 ms +0.8%
stablecoin_1-6 286.0 μs 289.3 μs +1.2%
stablecoin_2-1 1.110 ms 1.127 ms +1.5%
stablecoin_2-2 217.8 μs 222.1 μs +2.0%
stablecoin_2-3 1.272 ms 1.290 ms +1.4%
stablecoin_2-4 231.5 μs 235.1 μs +1.6%
token-account-1 225.0 μs 227.0 μs +0.9%
token-account-2 400.1 μs 402.0 μs +0.5%
uniswap-1 508.5 μs 511.7 μs +0.6%
uniswap-2 263.8 μs 265.7 μs +0.7%
uniswap-3 2.036 ms 2.053 ms +0.8%
uniswap-4 381.9 μs 384.6 μs +0.7%
uniswap-5 1.394 ms 1.407 ms +0.9%
uniswap-6 367.9 μs 370.9 μs +0.8%
vesting-1 430.4 μs 436.2 μs +1.3%

@effectfully effectfully force-pushed the effectfully/builtins/drop-val-from-KnownType-stuff-2 branch from c00a346 to 6ec3c2c Compare April 13, 2022 18:07
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '65b2c34d5' (base) and '6ec3c2c17' (PR)

Results table
Script 65b2c34 6ec3c2c Change
auction_1-1 204.3 μs 205.1 μs +0.4%
auction_1-2 819.2 μs 820.2 μs +0.1%
auction_1-3 806.3 μs 809.7 μs +0.4%
auction_1-4 259.0 μs 261.2 μs +0.8%
auction_2-1 204.6 μs 206.0 μs +0.7%
auction_2-2 815.2 μs 823.8 μs +1.1%
auction_2-3 1.029 ms 1.041 ms +1.2%
auction_2-4 805.6 μs 811.1 μs +0.7%
auction_2-5 259.2 μs 262.0 μs +1.1%
crowdfunding-success-1 239.1 μs 242.7 μs +1.5%
crowdfunding-success-2 239.3 μs 242.9 μs +1.5%
crowdfunding-success-3 239.4 μs 242.3 μs +1.2%
currency-1 300.1 μs 301.9 μs +0.6%
escrow-redeem_1-1 427.4 μs 433.0 μs +1.3%
escrow-redeem_1-2 428.0 μs 432.1 μs +1.0%
escrow-redeem_2-1 503.5 μs 508.1 μs +0.9%
escrow-redeem_2-2 504.2 μs 508.0 μs +0.8%
escrow-redeem_2-3 504.4 μs 507.2 μs +0.6%
escrow-refund-1 181.3 μs 183.4 μs +1.2%
future-increase-margin-1 301.5 μs 301.8 μs +0.1%
future-increase-margin-2 679.5 μs 682.4 μs +0.4%
future-increase-margin-3 679.9 μs 682.2 μs +0.3%
future-increase-margin-4 635.1 μs 640.6 μs +0.9%
future-increase-margin-5 1.007 ms 1.015 ms +0.8%
future-pay-out-1 300.4 μs 301.5 μs +0.4%
future-pay-out-2 676.8 μs 684.1 μs +1.1%
future-pay-out-3 678.0 μs 684.7 μs +1.0%
future-pay-out-4 1.004 ms 1.013 ms +0.9%
future-settle-early-1 299.9 μs 300.4 μs +0.2%
future-settle-early-2 675.6 μs 682.9 μs +1.1%
future-settle-early-3 677.3 μs 684.9 μs +1.1%
future-settle-early-4 768.6 μs 778.5 μs +1.3%
game-sm-success_1-1 484.4 μs 490.6 μs +1.3%
game-sm-success_1-2 222.9 μs 223.6 μs +0.3%
game-sm-success_1-3 802.1 μs 811.1 μs +1.1%
game-sm-success_1-4 259.2 μs 258.8 μs -0.2%
game-sm-success_2-1 485.6 μs 487.4 μs +0.4%
game-sm-success_2-2 224.4 μs 221.8 μs -1.2%
game-sm-success_2-3 807.4 μs 806.6 μs -0.1%
game-sm-success_2-4 260.2 μs 260.1 μs -0.0%
game-sm-success_2-5 804.7 μs 809.2 μs +0.6%
game-sm-success_2-6 259.0 μs 258.4 μs -0.2%
multisig-sm-1 499.4 μs 502.8 μs +0.7%
multisig-sm-2 488.4 μs 490.8 μs +0.5%
multisig-sm-3 492.9 μs 498.8 μs +1.2%
multisig-sm-4 498.4 μs 503.8 μs +1.1%
multisig-sm-5 717.6 μs 726.1 μs +1.2%
multisig-sm-6 499.9 μs 506.6 μs +1.3%
multisig-sm-7 487.8 μs 493.4 μs +1.1%
multisig-sm-8 494.2 μs 500.8 μs +1.3%
multisig-sm-9 497.9 μs 504.2 μs +1.3%
multisig-sm-10 714.8 μs 726.4 μs +1.6%
ping-pong-1 409.7 μs 411.6 μs +0.5%
ping-pong-2 410.5 μs 412.6 μs +0.5%
ping-pong_2-1 241.8 μs 242.3 μs +0.2%
prism-1 186.1 μs 186.0 μs -0.1%
prism-2 523.5 μs 525.9 μs +0.5%
prism-3 440.1 μs 443.7 μs +0.8%
pubkey-1 155.5 μs 156.5 μs +0.6%
stablecoin_1-1 1.113 ms 1.115 ms +0.2%
stablecoin_1-2 217.7 μs 218.6 μs +0.4%
stablecoin_1-3 1.269 ms 1.274 ms +0.4%
stablecoin_1-4 230.2 μs 231.9 μs +0.7%
stablecoin_1-5 1.585 ms 1.602 ms +1.1%
stablecoin_1-6 286.0 μs 287.2 μs +0.4%
stablecoin_2-1 1.111 ms 1.114 ms +0.3%
stablecoin_2-2 218.2 μs 219.2 μs +0.5%
stablecoin_2-3 1.270 ms 1.275 ms +0.4%
stablecoin_2-4 231.1 μs 231.5 μs +0.2%
token-account-1 223.9 μs 224.9 μs +0.4%
token-account-2 398.7 μs 402.3 μs +0.9%
uniswap-1 508.1 μs 512.1 μs +0.8%
uniswap-2 263.5 μs 266.5 μs +1.1%
uniswap-3 2.038 ms 2.064 ms +1.3%
uniswap-4 382.9 μs 385.6 μs +0.7%
uniswap-5 1.408 ms 1.415 ms +0.5%
uniswap-6 369.5 μs 369.4 μs -0.0%
vesting-1 432.0 μs 432.8 μs +0.2%

This was referenced Apr 14, 2022
Open
Closed
@effectfully
Copy link
Contributor Author

I like what is in here, but I don't think that making it work all the way is worth it, given that there are some other things that I really want to do with builtins and we agreed I shouldn't spend too much time on them anymore.

@effectfully effectfully closed this Jun 2, 2022
@effectfully effectfully mentioned this pull request Aug 16, 2022
Merged
@effectfully effectfully deleted the effectfully/builtins/drop-val-from-KnownType-stuff-2 branch November 10, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Builtins Don't look here yet Evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @iohk-devops