Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Evaluation] Make 'EvaluationResult' strict #4512

Merged
merged 1 commit into from
Mar 31, 2022
Merged

[Evaluation] Make 'EvaluationResult' strict #4512

merged 1 commit into from
Mar 31, 2022

Conversation

effectfully
Copy link
Contributor

I was looking at Core and that popped up. Let's see.

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'e59ade143' (base) and 'af1787988' (PR)

Script e59ade1 af17879 Change
auction_1-1 226.4 μs 219.5 μs -3.0%
auction_1-2 860.0 μs 852.6 μs -0.9%
auction_1-3 851.1 μs 841.4 μs -1.1%
auction_1-4 294.3 μs 284.1 μs -3.5%
auction_2-1 227.5 μs 219.7 μs -3.4%
auction_2-2 857.9 μs 850.7 μs -0.8%
auction_2-3 1.092 ms 1.084 ms -0.7%
auction_2-4 850.9 μs 842.9 μs -0.9%
auction_2-5 294.5 μs 286.0 μs -2.9%
crowdfunding-success-1 266.8 μs 258.4 μs -3.1%
crowdfunding-success-2 266.7 μs 258.2 μs -3.2%
crowdfunding-success-3 267.0 μs 257.8 μs -3.4%
currency-1 321.4 μs 316.4 μs -1.6%
escrow-redeem_1-1 465.6 μs 454.4 μs -2.4%
escrow-redeem_1-2 466.6 μs 454.5 μs -2.6%
escrow-redeem_2-1 547.4 μs 533.2 μs -2.6%
escrow-redeem_2-2 545.6 μs 532.6 μs -2.4%
escrow-redeem_2-3 546.7 μs 534.6 μs -2.2%
escrow-refund-1 200.4 μs 195.6 μs -2.4%
future-increase-margin-1 322.1 μs 316.5 μs -1.7%
future-increase-margin-2 723.1 μs 707.8 μs -2.1%
future-increase-margin-3 723.3 μs 707.8 μs -2.1%
future-increase-margin-4 675.5 μs 665.0 μs -1.6%
future-increase-margin-5 1.053 ms 1.043 ms -0.9%
future-pay-out-1 320.4 μs 317.8 μs -0.8%
future-pay-out-2 721.6 μs 713.6 μs -1.1%
future-pay-out-3 725.2 μs 713.4 μs -1.6%
future-pay-out-4 1.055 ms 1.040 ms -1.4%
future-settle-early-1 322.2 μs 316.5 μs -1.8%
future-settle-early-2 722.6 μs 709.9 μs -1.8%
future-settle-early-3 723.2 μs 711.2 μs -1.7%
future-settle-early-4 807.5 μs 793.8 μs -1.7%
game-sm-success_1-1 524.5 μs 515.8 μs -1.7%
game-sm-success_1-2 250.3 μs 241.4 μs -3.6%
game-sm-success_1-3 852.0 μs 834.3 μs -2.1%
game-sm-success_1-4 289.2 μs 283.7 μs -1.9%
game-sm-success_2-1 527.9 μs 515.7 μs -2.3%
game-sm-success_2-2 249.1 μs 242.4 μs -2.7%
game-sm-success_2-3 851.3 μs 836.5 μs -1.7%
game-sm-success_2-4 289.1 μs 283.1 μs -2.1%
game-sm-success_2-5 847.1 μs 834.7 μs -1.5%
game-sm-success_2-6 289.5 μs 283.9 μs -1.9%
multisig-sm-1 537.9 μs 533.0 μs -0.9%
multisig-sm-2 527.4 μs 519.6 μs -1.5%
multisig-sm-3 533.4 μs 526.0 μs -1.4%
multisig-sm-4 539.3 μs 531.6 μs -1.4%
multisig-sm-5 752.9 μs 745.0 μs -1.0%
multisig-sm-6 538.4 μs 530.8 μs -1.4%
multisig-sm-7 526.7 μs 518.7 μs -1.5%
multisig-sm-8 535.2 μs 525.7 μs -1.8%
multisig-sm-9 540.8 μs 528.1 μs -2.3%
multisig-sm-10 756.0 μs 743.5 μs -1.7%
ping-pong-1 441.5 μs 434.5 μs -1.6%
ping-pong-2 441.3 μs 434.2 μs -1.6%
ping-pong_2-1 263.2 μs 255.5 μs -2.9%
prism-1 209.4 μs 202.5 μs -3.3%
prism-2 567.6 μs 556.6 μs -1.9%
prism-3 481.0 μs 468.6 μs -2.6%
pubkey-1 175.8 μs 171.3 μs -2.6%
stablecoin_1-1 1.176 ms 1.167 ms -0.8%
stablecoin_1-2 243.0 μs 237.1 μs -2.4%
stablecoin_1-3 1.345 ms 1.332 ms -1.0%
stablecoin_1-4 259.1 μs 249.8 μs -3.6%
stablecoin_1-5 1.692 ms 1.679 ms -0.8%
stablecoin_1-6 319.8 μs 314.1 μs -1.8%
stablecoin_2-1 1.177 ms 1.170 ms -0.6%
stablecoin_2-2 242.8 μs 237.4 μs -2.2%
stablecoin_2-3 1.345 ms 1.335 ms -0.7%
stablecoin_2-4 259.5 μs 251.2 μs -3.2%
token-account-1 244.3 μs 237.9 μs -2.6%
token-account-2 432.1 μs 421.4 μs -2.5%
uniswap-1 537.2 μs 531.3 μs -1.1%
uniswap-2 288.6 μs 281.1 μs -2.6%
uniswap-3 2.187 ms 2.159 ms -1.3%
uniswap-4 433.5 μs 416.5 μs -3.9%
uniswap-5 1.507 ms 1.491 ms -1.1%
uniswap-6 415.6 μs 400.2 μs -3.7%
vesting-1 461.0 μs 455.8 μs -1.1%

@effectfully
Copy link
Contributor Author

-1.97% on average.

@michaelpj
Copy link
Contributor

Easy wins! Remind me why we're not using StrictData everywhere yet???

@michaelpj michaelpj merged commit 2fd1de8 into master Mar 31, 2022
@effectfully effectfully deleted the effectfully/evaluation/strict-EvaluationResult branch March 31, 2022 08:49
@effectfully
Copy link
Contributor Author

Easy wins! Remind me why we're not using StrictData everywhere yet???

I strongly believe that should be the default and all laziness in data types (not functions) should be explicit. In Zonk I just enabled StrictData globally.

@effectfully effectfully mentioned this pull request Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
Evaluation Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effectfully @iohk-devops @michaelpj