[Builtins] Fuse 'AsConstant' and 'FromConstant' into 'HasConstantIn' #4417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had to have two classes because of the way costing was aligned, but that has changed, so now we can unite these classes. I also dropped 'HasConstant', because we don't need it.
|
/benchmark plutus-benchmark:validation |
|
Comparing benchmark results of 'plutus-benchmark:validation' on '0397f83b8' (base) and 'b1d046796' (PR)
|
|
Damn it. |
|
/benchmark plutus-benchmark:validation |
|
Comparing benchmark results of 'plutus-benchmark:validation' on '0397f83b8' (base) and '41a1f8d29' (PR)
|
|
^ no change in performance. Good to know that a "harmless" equality constraint can cost us that much. Ready for review. |
michaelpj
approved these changes
Feb 21, 2022
| -- Switching from 'MonadError' to 'Either' here gave us a speedup of 2-4%. | ||
| -- | Unlift from the 'Constant' constructor throwing an 'UnliftingError' if the provided @term@ | ||
| -- is not a 'Constant'. | ||
| asConstant | ||
| :: AsUnliftingError err | ||
| => Maybe cause -> term -> Either (ErrorWithCause err cause) (Some (ValueOf (UniOf term))) | ||
|
|
||
| class FromConstant term where | ||
| -- | Wrap a Haskell value as a @term@. | ||
| fromConstant :: Some (ValueOf (UniOf term)) -> term |
There was a problem hiding this comment.
nit: maybe asConstant should be toConstant for symmetry.
There was a problem hiding this comment.
I use the convention of calling things that can fail as* and things that can't to*/from*. We have that with errors too, AsParseError, AsTypeError etc.
effectfully
deleted the
effectfully/builtins/fuse-AsConstant-and-FromConstant-into-HasConstantIn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to have two classes because of the way costing was aligned,
but that has changed, so now we can unite these classes.
I also dropped
HasConstant, because we don't need it.