Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-2380: Fixing scripts in plutus-use-cases-scripts #3457

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

koslambrou
Copy link
Contributor

There was another PR solving this issue which was merged in master (#3446 ). However, it was pointed out that the Future contract would only partially work. Therefore, this PR addresses the issue.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff ]
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@koslambrou koslambrou requested a review from bezirg June 29, 2021 22:51
@michaelpj
Copy link
Contributor

Including the initial setup for each trace seems sensible indeed!

@michaelpj michaelpj merged commit abbfd1c into master Jul 1, 2021
@kwxm kwxm deleted the scp-2380-future-fix-scripts branch October 12, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants