Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-2438 - Add formatting to constant params #3456

Merged
merged 4 commits into from
Jul 1, 2021
Merged

SCP-2438 - Add formatting to constant params #3456

merged 4 commits into from
Jul 1, 2021

Conversation

palas
Copy link
Contributor

@palas palas commented Jun 29, 2021 •
edited
Loading

This PR essentially adds the formatting options to value template parameters in the same way as we added it for choices in SCP-2394, SCP-2408, and SCP-2409.

It also adds formatting to the errors when adding choices out of range (which was missing)

Probably easiest to look at the commits independently than the full diff at once

Deployed to: http://pablo.marlowe.iohkdev.io/

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@palas palas requested review from merivale and hrajchert June 29, 2021 22:01
@palas palas self-assigned this Jun 29, 2021
hrajchert
hrajchert approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... minor note, with this new formatter, does this description still makes sense? or should it now be "Amount of ADA..."

Screen Shot 2021-07-01 at 10 29 03

marlowe-playground-client/src/MetadataTab/View.purs Outdated Show resolved Hide resolved
marlowe-playground-client/src/SimulationPage/View.purs Outdated Show resolved Hide resolved
@palas
Copy link
Contributor Author

palas commented Jul 1, 2021 •
edited
Loading

LGTM... minor note, with this new formatter, does this description still makes sense? or should it now be "Amount of ADA..."

I think we probably can update it once Marlowe Run has the same, since metadata is for the simulator in the first place

@palas palas merged commit 003d908 into master Jul 1, 2021
@palas palas deleted the SCP-2438 branch July 1, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrajchert hrajchert hrajchert approved these changes

@merivale merivale Awaiting requested review from merivale

Assignees

@palas palas

Labels
User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @hrajchert