SCP-2441: Implement new welcome screen design. #3453
Conversation
| _welcomeState :: Traversal' State Welcome.State | ||
| _welcomeState = _subState <<< _Left |
There was a problem hiding this comment.
I like this renaming :)
Maybe it make sense to rename _playState into _runState in a following PR 🤔
There was a problem hiding this comment.
Yes, I've already made a start on precisely that. I was thinking of _dashboardState, and of combining it with the ContractHome stuff. Because the new designs explicitly call that screen the "dashboard", and because contacts and contract setup stuff will be on a modal instead of in their own screen.
We could go with _runState instead... 🤔 What's your preference? I think I've a slight preference for "dashboard", because the whole thing is now being called "run" (and at some point we should rename the directory), so we would effectively have Run = Welcome | Dashboard.
There was a problem hiding this comment.
Mmhmhm, I like both options instead of play. My only concern there is that Dashboard would be what is currently the ContractHome, but there are other screens inside that state.
There was a problem hiding this comment.
Yes, but there won't be other screens there after the next redesign.* That's why I said that contacts and contract setup stuff will be in the new sidebar modal thing in my previous comment (and not in separate screens, as now) - but I didn't explain what the thinking was there, sorry.
* There will be a screen for each contract inside the dashboard, but that feels right to me. The breadcrumb will be "Dashboard > My contract name".
|
|
||
| handleAction (WalletNicknameInputAction inputFieldAction) = toWalletNicknameInput $ InputField.handleAction inputFieldAction | ||
|
|
||
| handleAction (WalletIdInputAction inputFieldAction) = toWalletIdInput $ InputField.handleAction inputFieldAction | ||
|
|
||
| handleAction (PickupWallet walletNickname) = do | ||
| assign _pickingUp true | ||
| handleAction (ConnectWallet walletNickname) = do |
There was a problem hiding this comment.
I was a little disorianted with _connecting until I saw this. Why ConnectWallet and not UseWallet? What are we connecting?
There was a problem hiding this comment.
Yeah, it probably should be UseWallet. It's because before we had "Pickup" on the button and a "pickingUp" flag in the state, and "Picking up..." on the button when pickingUp == true. But "using" in that case doesn't make sense. Anyway, I'll try and think of something better and push it shortly.
Does what it says on the tin. Looks like the screenshots below. The "Choose wallet or paste key" input doesn't match the designs yet, but I'll do that in another PR - it will require changing the
InputField, so I'll need to make sure it doesn't break the other inputs. Also I might implement the newChoiceFormatmetadata at the same time.