Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-2440: Fix an error with address change request #3451

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

j-mueller
Copy link
Contributor

We can only respond to the request if the request's slot range is in the past (some time for the chain index to update itself). targetSlot is the earliest time at which we can answer the request, so we may need to wait a little before we submit it.

This caused the marlowe follower contract to miss the past updates when it is first started.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@j-mueller j-mueller requested a review from silky June 29, 2021 09:29
Copy link
Contributor

@silky silky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-mueller j-mueller merged commit 948d578 into master Jun 29, 2021
@kwxm kwxm deleted the scp-2440-json-follow branch October 12, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants