Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid decorators when doing a simulation reset #3447

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix invalid decorators when doing a simulation reset #3447

merged 1 commit into from
Jun 29, 2021

Conversation

hrajchert
Copy link
Contributor

@hrajchert hrajchert commented Jun 28, 2021 •
edited
Loading

Small PR to fix the decorations of the simulator when doing a reset.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@hrajchert hrajchert requested a review from merivale June 28, 2021 18:14
merivale
merivale approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@merivale merivale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hrajchert hrajchert merged commit 3ebb20c into master Jun 29, 2021
@hrajchert hrajchert deleted the hrajchert/scp-2362-fix-simulation-reset branch June 29, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merivale merivale merivale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrajchert @merivale