Slightly abstract over de Bruijn environments #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/index-env-zoo
branch
2 times, most recently
from
b782435 to
a40fe6a
Compare
bezirg
approved these changes
Jun 28, 2021
We're going to end up with a bunch of these, especially once we add a COLA based one. This adds a small abstraction so that we can easily swap the implementation out (although we should keep it monomorphic in the CEK machine iteslf). While I was at it, I pulled the environments stuff and their benchmarks out to an internal library and tidied the benchmarks a bit to make use of the new classs.
michaelpj
force-pushed
the
mpj/index-env-zoo
branch
from
a40fe6a to
cc98443
Compare
koslambrou
pushed a commit
that referenced
this pull request
Jun 29, 2021
We're going to end up with a bunch of these, especially once we add a COLA based one. This adds a small abstraction so that we can easily swap the implementation out (although we should keep it monomorphic in the CEK machine iteslf). While I was at it, I pulled the environments stuff and their benchmarks out to an internal library and tidied the benchmarks a bit to make use of the new classs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to end up with a bunch of these, especially once we add a
COLA based one. This adds a small abstraction so that we can easily swap
the implementation out (although we should keep it monomorphic in the
CEK machine iteslf).
While I was at it, I pulled the environments stuff and their benchmarks
out to an internal library and tidied the benchmarks a bit to make use
of the new classs.
Pre-submit checklist:
Pre-merge checklist: