SCP-2430 - Save contract nicknames locally in the browser. #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrajchert
approved these changes
Jun 25, 2021
|
Yeah, it's just going to be local for now. Simon and Russ really wanted them to be editable, and this is better than nothing. If we want to share the names, that's ultimately probably a job for the metadata server. |
koslambrou
pushed a commit
that referenced
this pull request
Jun 29, 2021
* Saving contract nicknames in localStorage. * Adding placeholder name for new contracts. * Making contract nicknames editable in the contract card. * Review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to make contract nicknames editable, and save these in localStorage. But while I was at it I tidied up the way localStorage things are handled, making the
ManageMarloweStoragecapability the only thing that interacts with localStorage directly. And removing the unwanted feature of prompting users to start using the wallet they were using last time (no longer saving this to localStorage).I also made an unrelated improvement along the way - deleting some duplicate metadata lenses, and moving some others into web-common-marlowe.