Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertFailedTransactions #3415

Merged

Conversation

luigy
Copy link
Contributor

@luigy luigy commented Jun 22, 2021

#3222 added validations to transactions in the Wallet Emulator that excluded invalid ones from being submitted to the chain, but assertFailedTransactions was only "listening" for transactions that have been submitted to the chain. This PR adds Validation Failed messages to the Wallet Emulator and updates failedTransactions to also "listen" for them to recover the previous behavior

Fixes #3338

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@luigy luigy force-pushed the ll/fix-assertFailedTransactions branch from 0bc490d to 455c643 Compare June 24, 2021 13:51
@luigy luigy requested a review from j-mueller June 24, 2021 13:51
@luigy luigy marked this pull request as ready for review June 24, 2021 16:26
@j-mueller j-mueller merged commit ac49a99 into IntersectMBO:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertFailedTransaction does not work
2 participants