Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToSchema instance for Rational (fix #3277). #3334

Merged
2 commits merged into from
Jun 10, 2021
Merged

Add ToSchema instance for Rational (fix #3277). #3334

2 commits merged into from
Jun 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2021 •
edited by ghost
Loading

Add ToSchema instance for Rational to fix #3277.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@ghost ghost requested review from michaelpj and j-mueller June 9, 2021 13:49
@ghost ghost merged commit 6658064 into master Jun 10, 2021
@ghost ghost deleted the add-toschema-rational branch June 10, 2021 18:45
@anton-k
Copy link
Contributor

anton-k commented Jun 11, 2021 •
edited
Loading

Thanks for that!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ToSchema instance for Rational
2 participants
@anton-k @j-mueller