Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plutus-playground: Delete unused field from EvaluationResult #2594

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

j-mueller
Copy link
Contributor

The field is not used anywhere on the client, and it's redundant anyway because the resultRollup field contains all the transactions.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • If you updated any cabal files or added Haskell packages:
    • $(nix-build default.nix -A plutus.updateMaterialized) to update the materialized Nix files
    • Update hie-*.yaml files if needed
  • If you changed any Haskell files:
    • $(nix-shell shell.nix --run fix-stylish-haskell) to fix any formatting issues
  • If you changed any Purescript files:
    • $(nix-shell shell.nix --run fix-purty) to fix any formatting issues

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@j-mueller j-mueller force-pushed the j-mueller/playground-delete-unused-field branch from 89913cb to 07a7c8e Compare January 12, 2021 07:48
@j-mueller j-mueller merged commit 5a858c2 into master Jan 14, 2021
@kwxm kwxm deleted the j-mueller/playground-delete-unused-field branch June 16, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants