Switch to hercules-ci/gitignore.nix for a cool 2x eval speedup #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
from
cdb29b6 to
212564b
Compare
|
... but the evaluations on this branch are actually taking longer???? I don't understand 😭 |
gilligan
approved these changes
Dec 2, 2020
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
2 times, most recently
from
53d66d5 to
af5df4a
Compare
|
Converting to draft until I can figure out what's going on with Hydra :( |
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
from
af5df4a to
a8e5a34
Compare
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
from
a8e5a34 to
ba352d3
Compare
|
Un-drafting so hydra will build it, want to see if this is still bad. |
|
(Spoiler: it was still slower :( ) |
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
2 times, most recently
from
d4bc9fd to
e06b370
Compare
|
Okay, this is now only slightly slower than master (or possibly no slower, it's within the amount that the master evaluation time varies by, so 🤷 ). I think overall it's therefore worth it, since it has better behaviour (e.g. reading parent gitignore files), and is more maintained. |
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
from
e06b370 to
a2cbb28
Compare
This is *slightly* slower on hydra, but has better behaviour like reading gitignore files from parent directories, and is the "recommended" one to use.
michaelpj
force-pushed
the
imp/gitignore-eval-times
branch
from
a2cbb28 to
cf491c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do remember this being problematic before, switching to the more
maintained project immediately gave us a 2x eval speedup...
Pre-submit checklist:
$(nix-build default.nix -A pkgsLocal.updateMaterialized)to update the materialized Nix fileshie-*.yamlfiles if needed$(nix-shell shell.nix --run fix-stylish-haskell)to fix any formatting issues$(nix-shell shell.nix --run fix-purty)to fix any formatting issuesPre-merge checklist: