Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the design of AssocMap.Map #5921

Open
ana-pantilie opened this issue Apr 23, 2024 · 0 comments
Open

Revisit the design of AssocMap.Map #5921

ana-pantilie opened this issue Apr 23, 2024 · 0 comments
Labels
Internal status: triaged

Comments

@ana-pantilie
Copy link
Contributor

The AssocMap.Map type is confusing, since a Map type is usually expected to provide a very similar interface to https://hackage.haskell.org/package/containers-0.7/docs/Data-Map-Strict.html and to have an optimal way of storing/looking up/dealing with collisions of keys. This type does not provide any of that, and many of the functions/instances associated with it don't even enforce that the resulting map is well-defined. Also

plutus/plutus-tx/src/PlutusTx/AssocMap.hs

Line 244 in bcce392

union :: forall k v r. (Eq k) => Map k v -> Map k r -> Map k (These v r)
is non-standard.

See #5701 for more context.
@github-actions github-actions bot added the status: needs triage GH issues that requires triage label Apr 23, 2024
@ana-pantilie ana-pantilie added Internal status: triaged and removed status: needs triage GH issues that requires triage labels Apr 23, 2024
@ana-pantilie ana-pantilie mentioned this issue Apr 30, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internal status: triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ana-pantilie