Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new column and metric filter (Don't merge me) #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a new column and metric filter (Don't merge me) #19

wants to merge 1 commit into from

Conversation

popcornylu
Copy link
Contributor

@popcornylu popcornylu commented Feb 16, 2023 •
edited
Loading

This PR is for demo purpose

The change is

  1. Add a column (schema change)
  2. Add a filter to exclude the bot commits (metric calculation change)

The example comparison report link for this pr.

This is the screenshot of the report for metric changed
image

@github-actions

This comment was marked as outdated.

Sign in to view
@popcornylu popcornylu changed the title Add a new column and metric filter Add a new column and metric filter (Don't merge me) Feb 16, 2023
@popcornylu
Copy link
Contributor Author

popcornylu commented Feb 16, 2023 •
edited
Loading

@ctiml Should we exclude the bot commit in the model query rather than metric filter?

@wcchang1115 wcchang1115 force-pushed the feature/update-models branch 2 times, most recently from b2a0a33 to 9f1efb9 Compare April 25, 2023 07:13
@github-actions

This comment was marked as outdated.

Sign in to view
@wcchang1115 wcchang1115 force-pushed the feature/update-models branch from 9f1efb9 to 7ee304d Compare April 25, 2023 07:27
@github-actions

This comment was marked as outdated.

Sign in to view
@popcornylu popcornylu force-pushed the feature/update-models branch 3 times, most recently from 0239993 to 7cf4570 Compare July 18, 2023 03:14
@github-actions

This comment was marked as outdated.

Sign in to view
@InfuseAI InfuseAI deleted a comment from github-actions bot Jul 18, 2023
@DaveFlynn DaveFlynn mentioned this pull request Jul 18, 2023
Closed
@github-actions

This comment was marked as outdated.

Sign in to view
@wcchang1115 wcchang1115 force-pushed the feature/update-models branch from 9c1dcae to 7cf4570 Compare August 24, 2023 10:05
@github-actions
Copy link

📊 Piperider Comparison Summary

Impact Summary

Code Changes

Added Removed Modified
0 0 2

Resource Impact

Potentially Impacted Assessed Impacted
6 6 assessed, 0 skipped 2

Resource Impact

Models

    Model Impact Columns
Rows Dbt Time Failed Tests All Tests
..dels/staging/stg_commits.sql Impacted 8 ($\color{green}{\text{ 1 }}$ / $\color{red}{\text{ 0 }}$ / $\color{orange}{\text{ 0 }}$) 40835 0:00:00.15 $\color{green}{\text{ (↓ -0.00) }}$ - -
models/marts/authors.sql Assessed not impacted 4 758 0:00:00.09 $\color{red}{\text{ (↑ 0.01) }}$ 0 1
models/marts/repos.sql Assessed not impacted 11 3 0:00:00.07 $\color{green}{\text{ (↓ -0.01) }}$ - -
..dels/marts/commit_weekly.sql Assessed not impacted 4 181 0:00:00.50 $\color{red}{\text{ (↑ 0.11) }}$ - -

Metrics

    Metric Impact Queries
total ($\color{orange}{\text{ change }}$)
Active authors Impacted 3 ($\color{orange}{\text{ 1 }}$)
Total commits Assessed not impacted 5

📎 Generated Comparison Report ZIP

Find it in the Github Action Runs Page

@wcchang1115 wcchang1115 force-pushed the feature/update-models branch from 7cf4570 to b7e28e1 Compare September 7, 2023 03:07
@github-actions

This comment was marked as outdated.

Sign in to view
@wcchang1115 @ctiml
Add a new column and metric filter
c15b78e 
Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Co-authored-by: Timothy Lee <ctiml@infuseai.io>
@wcchang1115 wcchang1115 force-pushed the feature/update-models branch from b7e28e1 to c15b78e Compare September 7, 2023 07:24
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

📊 Piperider Comparison Summary

Impact Summary

PipeRider Report

Code Changes

Added Removed Modified
0 0 1

Resource Impact

Potentially Impacted Assessed Impacted
2 2 assessed, 0 skipped 1

Resource Impact

Models

    Model Impact Columns
Rows Dbt Time Failed Tests All Tests
..dels/staging/stg_commits.sql Impacted 8 ($\color{green}{\text{ 1 }}$ / $\color{red}{\text{ 0 }}$ / $\color{orange}{\text{ 0 }}$) 41741 0:00:00.07 $\color{red}{\text{ (↑ 0.01) }}$ - -
models/marts/authors.sql Assessed not impacted 4 764 0:00:00.08 $\color{red}{\text{ (↑ 0.01) }}$ 0 1

Metrics

No changes detected

📎 Generated Comparison Report ZIP

Find it in the Github Action Runs Page

@github-actions
Copy link

📊 Piperider Comparison Summary

Impact Summary

PipeRider Report

Code Changes

Added Removed Modified
0 0 1

Resource Impact

Potentially Impacted Assessed Impacted
2 2 assessed, 0 skipped 1

Resource Impact

Models

    Model Impact Columns
Rows Dbt Time Failed Tests All Tests
..dels/staging/stg_commits.sql Impacted 8 ($\color{green}{\text{ 1 }}$ / $\color{red}{\text{ 0 }}$ / $\color{orange}{\text{ 0 }}$) 42706 0:00:00.13 $\color{red}{\text{ (↑ 0.06) }}$ - -
models/marts/authors.sql Assessed not impacted 4 774 0:00:00.11 $\color{red}{\text{ (↑ 0.04) }}$ 0 1

Metrics

No changes detected

📎 Generated Comparison Report ZIP

Find it in the Github Action Runs Page

@InfuseAI InfuseAI deleted a comment from shaheerpowerhouse Oct 30, 2023
@InfuseAI InfuseAI deleted a comment from CodiumAI-Agent Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popcornylu @wcchang1115