Azure App Config Label patch #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user selects a label, we fetch secrets using that label. When they don't we select all secrets with any label. Instead of selecting all labels, we should select secrets with empty label. This PR does just that. We set the label to be url encoded null.
We may want to do a drop down in the future where users can select from label options:
empty label,all labelandcustom. When user selects custom, we allow them to type it in. For now, this PR will work fine because if a org doesn't use labels at all, then they will be able to fetch all secrets. If they use, labels, they must select the label they want to import/sync.In this PR, i also added missing docs