Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error When Clicking on CA Table Row After Viewing Certificate in Certificate Authorities Tab #2787

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Mhammad-riyaz
Copy link

@Mhammad-riyaz Mhammad-riyaz commented Nov 24, 2024

Description 📣

Fixes #2786

This pull request addresses a bug in the Certificate Authorities section where clicking on a CA table row after selecting View Certificate results in a page error.

Root Cause
The issue arises due to two hooks, useGetCaCerts and useGetCaCert, which are both using the same query key ("ca-cert") for fetching data:

useGetCaCerts: Called when clicking on a CA table row, it fetches an array of objects.
useGetCaCert: Called when clicking on the three dots and selecting View Certificate, it fetches a single object.

Since both hooks are using the same query key, the cache will store only the most recent data fetched. On clicking on View Certificate the useGetCert hook is called which returns an object and this is stored in the cache, and now on clicking on the row (CA), the component tries to map over the data, since the object is in cache ,it cannot map over it resulting in the error.

Solution
The query key for useGetCaCerts has been updated from "ca-cert" to "ca-certs", ensuring that the two hooks use distinct cache keys and no longer conflict.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

getCaCerts: (caId: string) => [{ caId }, "ca-certs"],

@dangtony98 dangtony98 merged commit 550096e into Infisical:main Dec 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error Occurs When Clicking on CA Table Row After Viewing Certificate in Certificate Authorities Tab"
2 participants