Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BlockSparseArrays] Use new SparseArrayDOK type in BlockSparseArrays #1272

Merged
merged 34 commits into from
Dec 2, 2023

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Nov 30, 2023

TODO:

  • Get BlockSparseArray working with new SparseArrayDOK type. Seems to require an overload of getindex_notstored to construct a zero block matrix when accessing structurally zero blocks.

Other TODO items moved to #1250.

@mtfishman mtfishman marked this pull request as ready for review December 1, 2023 23:26
@mtfishman
Copy link
Member Author

[test ITensors mps]

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/7066309029

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Run ITensors mps tests from comment trigger: succeeded ✅
https://github.com/ITensor/ITensors.jl/actions/runs/7066309029

@mtfishman mtfishman merged commit d98794a into main Dec 2, 2023
10 checks passed
@mtfishman mtfishman deleted the NDTensors_new_BlockSparseArrays branch December 2, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant