add Phil's authoritative list of ITs for docker-aio and dataverse-ansible #7915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove reference to phoenix server, which has been decommissioned. We'll finished cleaning up phoenix-related docs in IQSS#7031.
pdurbin
requested changes
May 28, 2021
There was a problem hiding this comment.
Looks good but can we update the docs? I made a suggestion at uncch-rdmc#83
mention new IT test list in dev guide IQSS#7897
pdurbin
approved these changes
May 28, 2021
There was a problem hiding this comment.
Now that we have docs I think we're good. Thanks, @donsizemore ! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Multiple methods of running the IT suite relied on
conf/docker-aio/run-test-suite.shwhich was customized initially for docker-aio and improperly for dataverse-ansible. This PR removes CentOS 8 Maven cruft and instead reference Phil'stests/integration-tests.txt. dataverse-ansible has a branch prepared to pull from this list as well. Note that @poikilotherm 's preferredmvn verifywith the maven-failsafe-plugin is under preparation and pending community approval may appear as a separate pull request.Which issue(s) this PR closes:
Closes #7897
Special notes for your reviewer: dataverse-ansible has a corresponding branch which needs to be merged when this PR is merged. no big deal.
Suggestions on how to test this: run the modified script, either in docker-aio or locally
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: none